Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zero pages design #1513

Merged
merged 7 commits into from
Jan 2, 2018
Merged

Zero pages design #1513

merged 7 commits into from
Jan 2, 2018

Conversation

mad-anne
Copy link
Contributor

@mad-anne mad-anne commented Dec 20, 2017

This changes handling empty querysets in dashboard list views with is_empty flag.

Closes #1435

Pull Request Checklist

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. The changes are tested.
  6. The code is documented (docstrings, project documentation).
  7. Python code quality checks pass: pycodestyle, pydocstyle, pylint.
  8. JavaScript code quality checks pass: eslint.

@codecov-io
Copy link

codecov-io commented Dec 20, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@fc82502). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1513   +/-   ##
=========================================
  Coverage          ?   82.74%           
=========================================
  Files             ?      131           
  Lines             ?     5667           
  Branches          ?      642           
=========================================
  Hits              ?     4689           
  Misses            ?      813           
  Partials          ?      165
Impacted Files Coverage Δ
saleor/dashboard/category/views.py 82.75% <100%> (ø)
saleor/dashboard/order/views.py 56.67% <100%> (ø)
saleor/dashboard/discount/views.py 66.66% <100%> (ø)
saleor/dashboard/group/views.py 100% <100%> (ø)
saleor/dashboard/staff/views.py 100% <100%> (ø)
saleor/dashboard/customer/views.py 100% <100%> (ø)
saleor/dashboard/product/views.py 70.9% <100%> (ø)
saleor/dashboard/shipping/views.py 97.22% <100%> (ø)
saleor/dashboard/sites/views.py 96.49% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc82502...159ac2f. Read the comment docs.

@maarcingebala maarcingebala merged commit b113525 into saleor:master Jan 2, 2018
@mad-anne mad-anne deleted the zero-page branch January 8, 2018 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants