Block when tax failed #15292

kadewu · 2024-01-25T14:17:14Z

#12942

Needs fixes from: #15378
Zero downtime will be provided with those fixes.

Impact

New migrations
New/Updated API fields or mutations
Deprecated API fields or mutations
Removed API types, fields, or mutations

Docs

Link to documentation: Add taxes circuit break docs saleor-docs#1083

Pull Request Checklist

Privileged queries and mutations are either absent or guarded by proper permission checks
Database queries are optimized and the number of queries is constant
Database migrations are either absent or optimized for zero downtime
The changes are covered by test cases
All new fields/inputs/mutations have proper labels added (ADDED_IN_X, PREVIEW_FEATURE, etc.)
All migrations have proper dependencies
All indexes are added concurrently in migrations
All RunSql and RunPython migrations have revert option defined

db-queries · 2024-02-08T17:03:38Z

Here is the report for 3441ea5 (saleor:block-when-tax-failed)
Base comparison is 6aa2ddb.

Found 20 differences! (click me)

# saleor.graphql.accountbenchmark account
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  addresses for federation query count                                    	          9	          9	              2
  customers query                                                         	         51	         51	              0
  delete staff members                                                    	         41	         41	              0
  query staff user                                                        	         22	         22	              3
  staff create                                                            	         23	         23	              3
  staff update groups and permissions                                     	         36	         36	              5
  users for federation query count                                        	          8	          8	              3

# saleor.graphql.accountbenchmark permission group
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  groups for federation query count                                       	          5	          5	              0
  permission group create                                                 	         25	         25	              0
  permission group delete                                                 	         30	         30	              3
  permission group query                                                  	         14	         14	              0
  permission group update                                                 	         44	         44	              2
  permission group update remove users with manage staff                  	         36	         36	              3

# saleor.graphql.appbenchmarks app extensions
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  app extensions                                                          	         15	         15	              0
  app extensions with filter[filter0]                                     	         14	         14	              0
  app extensions with filter[filter1]                                     	         10	         10	              0
  app extensions with filter[filter2]                                     	         14	         14	              0
  app extensions with filter[filter3]                                     	         10	         10	              0

# saleor.graphql.appbenchmarks apps
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  apps for federation query count                                         	          9	          9	              3
  apps with tokens and webhooks                                           	          9	          9	              0

# saleor.graphql.attributebenchmark attribute
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  attribute translation                                                   	          6	          6	              0
  attribute value translation                                             	         20	         20	              0
  query attribute                                                         	          6	          6	              0
  query attributes                                                        	          8	          8	              0

# saleor.graphql.channelbenchmark channel
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  channels query                                                          	          5	          5	              0

# saleor.graphql.channelmutations channel update
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  channel update mutation remove warehouse                                	         38	         38	              6

# saleor.graphql.checkoutbenchmark checkout mutations
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
- add billing address to checkout                                         	         75	         76	             11
- add checkout lines                                                      	         80	         81	             12
- add checkout lines gift discount applies                                	        142	        143	             21
- add checkout lines order discount applies                               	        156	        157	             16
- add checkout lines with external shipping                               	        183	        184	             75
- add checkout lines with reservations                                    	        169	        171	             59
- add delivery to checkout                                                	         77	         78	             13
- add shipping to checkout                                                	         88	         89	             16
- checkout email update                                                   	         40	         41	              2
- checkout payment charge                                                 	         55	         56	             16
- checkout shipping address update                                        	         81	         82	             10
- checkout voucher code                                                   	        100	        101	             17
  complete checkout                                                       	        239	        239	             81
  complete checkout preorder                                              	        237	        237	             82
  complete checkout with digital line                                     	        280	        280	             95
  complete checkout with out of stock webhook                             	        241	        241	             81
  complete checkout with single line                                      	        241	        241	             81
- create checkout                                                         	         81	         82	              9
- create checkout with gift promotion                                     	        120	        121	             19
- create checkout with order promotion                                    	        103	        104	              9
- create checkout with reservations                                       	        147	        149	             27
  customer complete checkout                                              	        252	        252	             87
  customer complete checkout for cc                                       	        227	        227	             76
- update checkout lines                                                   	         73	         74	             12
- update checkout lines with reservations                                 	        175	        177	             72

# saleor.graphql.checkoutbenchmark checkouts
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  staff multiple checkouts                                                	          6	          6	              0

# saleor.graphql.checkoutbenchmark homepage
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
- user checkout details                                                   	         59	         60	              6
- user checkout details with tax app                                      	         53	         54	              3

# saleor.graphql.discountbenchmark promotion create
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  promotion create                                                        	         52	         52	              3
  promotion create order promotion                                        	         41	         41	              7

# saleor.graphql.discountbenchmark promotion delete
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  gift promotion delete                                                   	         24	         24	              1
  promotion delete                                                        	         32	         32	              1

# saleor.graphql.discountbenchmark promotion rule create
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  promotion rule create                                                   	         36	         36	              0
  promotion rule create gift                                              	        144	        144	              9

# saleor.graphql.discountbenchmark promotion rule delete
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  promotion rule delete                                                   	         22	         22	              0

# saleor.graphql.discountbenchmark promotion rule update
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  promotion rule update                                                   	         42	         42	              1

# saleor.graphql.discountbenchmark promotion update
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  promotion update                                                        	         38	         38	              1

# saleor.graphql.discountbenchmark promotions
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  promotions querytest promotions query                                   	          9	          9	              0

# saleor.graphql.discountbenchmark sales
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  sales query with channel slug                                           	          9	          9	              0
  sales query without channel slug                                        	          7	          7	              0

# saleor.graphql.discountbenchmark voucher code bulk delete
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  voucher code bulk delete queries                                        	         22	         22	              2

# saleor.graphql.discountbenchmark vouchers
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  vouchers query with channel slug                                        	         20	         20	              0
  vouchers query withot channel slug                                      	         19	         19	              0

# saleor.graphql.giftcardbenchmark gift card mutations
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  create never expiry gift card                                           	         26	         26	              4
  gift card bulk activate by staff                                        	         16	         16	              3
  update gift card                                                        	         36	         36	              4

# saleor.graphql.giftcardbenchmark gift card queries
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  filter gift cards by products                                           	         14	         14	              3
  filter gift cards by tags                                               	         12	         12	              3
  filter gift cards by used by user                                       	         13	         13	              3
  query gift card details                                                 	         14	         14	              3
  query gift cards                                                        	         12	         12	              3

# saleor.graphql.orderbenchmark fulfillment
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  fulfillment query                                                       	          6	          6	              0

# saleor.graphql.orderbenchmark fulfillment refund and return products
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  fulfillment refund products order lines                                 	         60	         60	              0
  fulfillment return products order lines                                 	        102	        102	              7

# saleor.graphql.orderbenchmark order
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  staff multiple draft orders                                             	          7	          7	              0
  staff multiple orders                                                   	          7	          7	              0
  staff order details                                                     	         56	         56	              7
  user order details                                                      	         54	         54	              8

# saleor.graphql.orderbenchmark order bulk create
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  order bulk create                                                       	         21	         21	              2

# saleor.graphql.orderbenchmark order fulfill
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  order fulfill                                                           	         19	         19	              0
  order fulfill with gift cards                                           	         19	         19	              0

# saleor.graphql.orderbenchmark order lines create
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  order lines create                                                      	         94	         94	             17
  order lines create variants on promotion                                	        153	        153	             22

# saleor.graphql.pagebenchmark page type
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  page types for federation query count                                   	          3	          3	              0
  query page type                                                         	         18	         18	              6
  query page types                                                        	         25	         25	             12

# saleor.graphql.paymentbenchmark payment transactions
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  payment transactions                                                    	         54	         54	             20

# saleor.graphql.productbenchmark category
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  categories children                                                     	          3	          3	              0
  categories for federation query count                                   	          3	          3	              0
  category delete                                                         	         65	         65	              9
  category view                                                           	         33	         33	              4

# saleor.graphql.productbenchmark collection
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  collection add products                                                 	         46	         46	              8
  collection bulk delete                                                  	         54	         54	              6
  collection view                                                         	         11	         11	              3
  collections for federation query count                                  	          6	          6	              0
  create collection                                                       	         37	         37	              5
  delete collection                                                       	         51	         51	              7
  remove products from collection                                         	         43	         43	              8
  retrieve collection channel listings                                    	          5	          5	              0

# saleor.graphql.productbenchmark homepage
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  report product sales                                                    	         10	         10	              3
  retrieve product list                                                   	          4	          4	              0

# saleor.graphql.productbenchmark product
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  filter products by attributes                                           	         10	         10	              1
  filter products by boolean attributes                                   	         17	         17	              1
  filter products by gift card                                            	         14	         14	              2
  filter products by numeric attributes                                   	         16	         16	              1
  product create                                                          	         63	         63	              3
  product details                                                         	         46	         46	              4
  product translations                                                    	          8	          8	              1
  products for federation query count                                     	         12	         12	              4
  products media for federation query count                               	          5	          5	              0
  products types for federation query count                               	          2	          2	              0
  retrieve channel listings                                               	         20	         20	              0
  retrieve product attributes                                             	         11	         11	              1
  retrieve product images                                                 	          7	          7	              1
  retrieve product media                                                  	          7	          7	              1
  retrive products with product types and attributes                      	         10	         10	              1
  update product                                                          	         85	         85	              5

# saleor.graphql.productbenchmark product variant channel listing update
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  variant channel listing update                                          	         47	         47	              3

# saleor.graphql.productbenchmark variant
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  product variant bulk create                                             	         55	         55	              1
  product variant create                                                  	         69	         69	              3
  products variants for federation query count                            	         10	         10	              3
  retrieve variant list                                                   	         37	         37	              2
  update product variant                                                  	         68	         68	              6

# saleor.graphql.productbenchmark variant stocks
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  product variants stocks create                                          	         29	         29	              4
  product variants stocks create with single webhook called               	         28	         28	              4
  product variants stocks delete by id                                    	         30	         30	              4
  product variants stocks delete by sku                                   	         30	         30	              4
  product variants stocks delete with out of stock webhook many calls     	         26	         26	              3
  product variants stocks update by sku                                   	         28	         28	              4
  product variants stocks update byid                                     	         28	         28	              4
  query product variants stocks                                           	         10	         10	              0

# saleor.graphql.producttest product sorting attributes
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  sort product not having attribute data                                  	         20	         20	              0

# saleor.graphql.shippingbenchmark shipping methods
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  vouchers query with channel slug                                        	          7	          7	              0
  vouchers query without channel slug                                     	          7	          7	              0

# saleor.graphql.shippingbenchmark shipping zones
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  shipping zones query                                                    	          6	          6	              0

# saleor.graphql.shopbenchmark homepage
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  retrieve shop                                                           	          2	          2	              0

# saleor.graphql.warehousebenchmark stock bulk update
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  stocks bulk update queries count                                        	         33	         33	              5

# saleor.graphql.warehousebenchmark stocks
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  stocks query                                                            	          5	          5	              0

# saleor.graphql.webhookbenchmark webhook events
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  webhooks                                                                	          6	          6	              0

codecov · 2024-02-09T12:10:14Z

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (6aa2ddb) 93.92% compared to head (3441ea5) 93.92%.
Report is 2 commits behind head on main.

Files	Patch %	Lines
saleor/plugins/webhook/plugin.py	85.71%	2 Missing and 1 partial ⚠️
saleor/checkout/calculations.py	90.00%	2 Missing ⚠️
saleor/order/calculations.py	90.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #15292      +/-   ##
==========================================
- Coverage   93.92%   93.92%   -0.01%     
==========================================
  Files         929      930       +1     
  Lines       70720    70833     +113     
  Branches     8216     8236      +20     
==========================================
+ Hits        66422    66528     +106     
- Misses       2760     2766       +6     
- Partials     1538     1539       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

As it technically possible on database level that app.identifier will be blank string, leave the tests and logic to check that. But it should not happen from logic point of view.

add more tests and descriptions

saleor/app/utils.py

saleor/checkout/calculations.py

saleor/graphql/app/mutations/app_create.py

saleor/graphql/tax/mutations/tax_configuration_update.py

saleor/plugins/webhook/plugin.py

kadewu added skip changelog test deployment Deploy test environment for pull request labels Jan 25, 2024

github-actions bot temporarily deployed to block-when-tax-failed January 25, 2024 14:18 Inactive

github-actions bot temporarily deployed to block-when-tax-failed January 29, 2024 08:47 Inactive

kadewu added test deployment Deploy test environment for pull request and removed test deployment Deploy test environment for pull request labels Jan 29, 2024

github-actions bot temporarily deployed to block-when-tax-failed January 29, 2024 09:22 Inactive

krzysztofzuraw mentioned this pull request Jan 29, 2024

[SHOPX-66] Select tax app on taxes configuration saleor/saleor-dashboard#4631

Merged

7 tasks

kadewu added test deployment Deploy test environment for pull request and removed test deployment Deploy test environment for pull request labels Jan 30, 2024

github-actions bot temporarily deployed to block-when-tax-failed January 31, 2024 12:17 Inactive

github-actions bot temporarily deployed to block-when-tax-failed February 1, 2024 08:59 Inactive

kadewu force-pushed the block-when-tax-failed branch from b4b0bc1 to db3a39b Compare February 8, 2024 12:41

github-actions bot temporarily deployed to block-when-tax-failed February 8, 2024 12:41 Inactive

github-actions bot temporarily deployed to block-when-tax-failed February 8, 2024 12:46 Inactive

kadewu added this to the Saleor 3.19 milestone Feb 8, 2024

kadewu removed the test deployment Deploy test environment for pull request label Feb 8, 2024

kadewu mentioned this pull request Feb 9, 2024

Fix setting invalid identifier #15378

Merged

13 tasks

kadewu force-pushed the block-when-tax-failed branch from 8408910 to 2e1e573 Compare February 9, 2024 11:04

kadewu added migrations perf test Runs performance tests on modified migrations test deployment Deploy test environment for pull request and removed skip changelog labels Feb 9, 2024

github-actions bot temporarily deployed to block-when-tax-failed February 9, 2024 11:05 Inactive

github-actions bot temporarily deployed to block-when-tax-failed February 9, 2024 11:44 Inactive

kadewu mentioned this pull request Feb 9, 2024

Add taxes circuit break docs saleor/saleor-docs#1083

Merged

kadewu marked this pull request as ready for review February 9, 2024 12:27

kadewu requested review from tomaszszymanski129 and korycins February 9, 2024 12:28

kadewu added 14 commits February 13, 2024 10:36

Add checkout circuit break

2934acb

Add backward compatibility

4070520

Add tests

a7e9cca

Remove flag to control if taxes are required

85db188

Fix mypy

ce0feba

Use blank instead of none app identifier in tests

bf098ff

As it technically possible on database level that app.identifier will be blank string, leave the tests and logic to check that. But it should not happen from logic point of view.

Add more tests

e8d84c0

Add possibility to stop checkout process in more places

1888fa1

Add country codes to errors

f995f07

add more tests and descriptions

update changelog

4512abd

update taxAppId description

cc87cf4

fix benchmarks after rebase

6cb8e39

Remove migration after changing base

e01035a

Review fixes

a28e5f3

kadewu force-pushed the block-when-tax-failed branch from 00f5c8c to a28e5f3 Compare February 13, 2024 09:36

github-actions bot temporarily deployed to block-when-tax-failed February 13, 2024 09:37 Inactive

apply ruff-format after rebase

1f30fc8

github-actions bot temporarily deployed to block-when-tax-failed February 13, 2024 09:44 Inactive

maarcingebala approved these changes Feb 13, 2024

View reviewed changes

korycins reviewed Feb 13, 2024

View reviewed changes

Do not try to call tax app if app is not responding

c709737

github-actions bot temporarily deployed to block-when-tax-failed February 13, 2024 14:48 Inactive

korycins approved these changes Feb 13, 2024

View reviewed changes

kadewu added 3 commits February 13, 2024 18:56

Refactor available_tax_apps

002c076

Refactor webhook plugin

9fa2043

fixes

3441ea5

kadewu removed the test deployment Deploy test environment for pull request label Feb 13, 2024

github-actions bot deployed to block-when-tax-failed February 13, 2024 18:51 View deployment

kadewu merged commit 6ee567d into main Feb 13, 2024
15 of 17 checks passed

kadewu deleted the block-when-tax-failed branch February 13, 2024 19:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Block when tax failed #15292

Block when tax failed #15292

kadewu commented Jan 25, 2024 •

edited

db-queries bot commented Feb 8, 2024 •

edited

codecov bot commented Feb 9, 2024 •

edited

Block when tax failed #15292

Block when tax failed #15292

Conversation

kadewu commented Jan 25, 2024 • edited

Impact

Docs

Pull Request Checklist

db-queries bot commented Feb 8, 2024 • edited

codecov bot commented Feb 9, 2024 • edited

Codecov Report

kadewu commented Jan 25, 2024 •

edited

db-queries bot commented Feb 8, 2024 •

edited

codecov bot commented Feb 9, 2024 •

edited