Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust impersonate settings #1543

Merged
merged 2 commits into from
Jan 2, 2018
Merged

Adjust impersonate settings #1543

merged 2 commits into from
Jan 2, 2018

Conversation

Pacu2
Copy link
Contributor

@Pacu2 Pacu2 commented Jan 2, 2018

I want to merge this change because...
Close #1542
(Please mention all relevant issue numbers.)

(If your changes affect the UI, providing "before" and "after" screenshots will
greatly reduce the amount of work needed to review your work.)

Pull Request Checklist

(Please keep this section. It will make maintainer's life easier.)

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. The changes are tested.
  6. The code is documented (docstrings, project documentation).
  7. Python code quality checks pass: pycodestyle, pydocstyle, pylint.
  8. JavaScript code quality checks pass: eslint.

@codecov-io
Copy link

Codecov Report

Merging #1543 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1543   +/-   ##
=======================================
  Coverage   82.67%   82.67%           
=======================================
  Files         131      131           
  Lines        5704     5704           
  Branches      642      642           
=======================================
  Hits         4716     4716           
  Misses        823      823           
  Partials      165      165

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c8d89d...6a3bdc8. Read the comment docs.

@maarcingebala maarcingebala merged commit 46ce270 into master Jan 2, 2018
@maarcingebala maarcingebala deleted the fix/impersonate-settings branch January 2, 2018 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants