Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update get_user_id to get_user since it is removed after django 2.1 #2820

Merged
merged 1 commit into from Sep 11, 2018

Conversation

jxltom
Copy link
Contributor

@jxltom jxltom commented Sep 11, 2018

get_user_id is removed after django 2.1. Refer to django/django@fe99fb8

So update get_user_id to get_user in tests to make saleor compatible with django which version are newer than 2.1

Pull Request Checklist

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. The changes are tested.
  6. The code is documented (docstrings, project documentation).

@codecov
Copy link

codecov bot commented Sep 11, 2018

Codecov Report

Merging #2820 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2820   +/-   ##
=======================================
  Coverage   89.32%   89.32%           
=======================================
  Files         207      207           
  Lines       10489    10489           
  Branches     1011     1011           
=======================================
  Hits         9369     9369           
  Misses        803      803           
  Partials      317      317

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33329a5...ea28a7c. Read the comment docs.

@patrys patrys merged commit 535d41d into saleor:master Sep 11, 2018
@jxltom jxltom deleted the fixed-tests-in-django2.1 branch September 11, 2018 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants