Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add first and last name to customer and staff module #3247

Merged

Conversation

bonifacy1
Copy link
Contributor

Todo:

  • - Add first and last name to staff module
  • - Add First and last name to customers module

Issue:
close #3181

@dominik-zeglen dominik-zeglen force-pushed the Add/first-and-last-name-to-customer-and-staff-module branch from 03975c3 to 493180a Compare December 14, 2018 10:08
@codecov
Copy link

codecov bot commented Dec 14, 2018

Codecov Report

Merging #3247 into master will decrease coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3247      +/-   ##
==========================================
- Coverage    89.7%   89.42%   -0.29%     
==========================================
  Files         237      222      -15     
  Lines       12901    12411     -490     
  Branches     1301     1234      -67     
==========================================
- Hits        11573    11098     -475     
+ Misses        922      920       -2     
+ Partials      406      393      -13
Impacted Files Coverage Δ
saleor/core/templatetags/attributes.py 77.77% <0%> (-22.23%) ⬇️
saleor/dashboard/taxes/views.py 83.01% <0%> (-16.99%) ⬇️
saleor/graphql/core/types/money.py 91.48% <0%> (-8.52%) ⬇️
saleor/payment/gateways/dummy/__init__.py 95.91% <0%> (-4.09%) ⬇️
saleor/payment/utils.py 95.45% <0%> (-2.28%) ⬇️
saleor/search/documents.py 75% <0%> (-2.2%) ⬇️
saleor/graphql/api.py 98.13% <0%> (-1.87%) ⬇️
saleor/account/utils.py 63.63% <0%> (-1.59%) ⬇️
saleor/account/views.py 79.12% <0%> (-1.5%) ⬇️
saleor/account/forms.py 83.56% <0%> (-1.06%) ⬇️
... and 58 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad91ae8...493180a. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 14, 2018

Codecov Report

Merging #3247 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3247   +/-   ##
=======================================
  Coverage   89.75%   89.75%           
=======================================
  Files         237      237           
  Lines       12943    12943           
  Branches     1312     1312           
=======================================
  Hits        11617    11617           
  Misses        922      922           
  Partials      404      404

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf652d7...8b909a2. Read the comment docs.

@dominik-zeglen dominik-zeglen force-pushed the Add/first-and-last-name-to-customer-and-staff-module branch from ff48067 to 62358cf Compare December 14, 2018 15:20
@maarcingebala maarcingebala merged commit 3cbe16d into master Dec 17, 2018
@maarcingebala maarcingebala deleted the Add/first-and-last-name-to-customer-and-staff-module branch December 17, 2018 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add First and last name in react dashboard
4 participants