Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resort imports by isort #3412

Merged
merged 1 commit into from
Dec 10, 2018
Merged

Resort imports by isort #3412

merged 1 commit into from
Dec 10, 2018

Conversation

jxltom
Copy link
Contributor

@jxltom jxltom commented Dec 7, 2018

Some imports are not sorted correctly, this PR resort all imports under saleor by isort -rc saleor.

Pull Request Checklist

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. Database migration files are up to date.
  6. The changes are tested.
  7. The code is documented (docstrings, project documentation).
  8. GraphQL schema and type definitions are up to date.

@dominik-zeglen
Copy link
Contributor

dominik-zeglen commented Dec 7, 2018

I believe some of these are not sorted on purpose because of side effects. Did you test it?
EDIT: don't mind me, "The changes are tested" checkbox is checked :)

@codecov
Copy link

codecov bot commented Dec 7, 2018

Codecov Report

Merging #3412 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3412   +/-   ##
=======================================
  Coverage   89.65%   89.65%           
=======================================
  Files         237      237           
  Lines       12783    12783           
  Branches     1282     1282           
=======================================
  Hits        11460    11460           
  Misses        921      921           
  Partials      402      402
Impacted Files Coverage Δ
saleor/graphql/core/types/common.py 96.15% <ø> (ø) ⬆️
saleor/graphql/descriptions.py 100% <ø> (ø) ⬆️
saleor/graphql/shipping/resolvers.py 100% <ø> (ø) ⬆️
saleor/dashboard/staff/filters.py 100% <ø> (ø) ⬆️
saleor/graphql/core/fields.py 94.28% <100%> (ø) ⬆️
saleor/graphql/product/resolvers.py 94.93% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d680636...ab73ab4. Read the comment docs.

@jxltom
Copy link
Contributor Author

jxltom commented Dec 7, 2018

Hey, thanks for reminding me.

To be honest, this PR mostly only removes the blank line between the import. The only one may has issue is this part https://github.com/mirumee/saleor/pull/3412/files#diff-df253f868649956cf350ce28d0fecc7c. But that one only sorts two third-party packges. So i think this PR is safe. :)

@jxltom
Copy link
Contributor Author

jxltom commented Dec 7, 2018

Update: the codeclimate is still warning one sorting issue. But I think that one can be safely ignored since I actually didn't touch that part of code and that file saleor/graphql/core/types/common.py is sorted by isort indeed.

@NyanKiyoshi
Copy link
Member

A rebase should fix the issue I think. But that's fine.

@maarcingebala maarcingebala merged commit 07b7d2d into saleor:master Dec 10, 2018
@maarcingebala
Copy link
Member

Thanks @jxltom, code style improvements are always welcomed!

@jxltom jxltom deleted the resort-imports branch December 13, 2018 01:29
@jxltom jxltom mentioned this pull request Dec 17, 2018
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants