-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resort imports by isort #3412
Resort imports by isort #3412
Conversation
I believe some of these are not sorted on purpose because of side effects. Did you test it? |
Codecov Report
@@ Coverage Diff @@
## master #3412 +/- ##
=======================================
Coverage 89.65% 89.65%
=======================================
Files 237 237
Lines 12783 12783
Branches 1282 1282
=======================================
Hits 11460 11460
Misses 921 921
Partials 402 402
Continue to review full report at Codecov.
|
Hey, thanks for reminding me. To be honest, this PR mostly only removes the blank line between the |
Update: the codeclimate is still warning one sorting issue. But I think that one can be safely ignored since I actually didn't touch that part of code and that file |
A rebase should fix the issue I think. But that's fine. |
6a34e9d
to
ab73ab4
Compare
Thanks @jxltom, code style improvements are always welcomed! |
Some imports are not sorted correctly, this PR resort all imports under
saleor
byisort -rc saleor
.Pull Request Checklist