Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add payment authorize and charge mutation #3426

Merged
merged 8 commits into from Dec 14, 2018

Conversation

jxltom
Copy link
Contributor

@jxltom jxltom commented Dec 10, 2018

This PR adds payment's authorize and charge mutation, as well as the tests. Ready for view.

Pull Request Checklist

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. Database migration files are up to date.
  6. The changes are tested.
  7. The code is documented (docstrings, project documentation).
  8. GraphQL schema and type definitions are up to date.

@codecov
Copy link

codecov bot commented Dec 10, 2018

Codecov Report

Merging #3426 into master will increase coverage by 0.04%.
The diff coverage is 90.69%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3426      +/-   ##
=========================================
+ Coverage   89.66%   89.7%   +0.04%     
=========================================
  Files         237     237              
  Lines       12860   12901      +41     
  Branches     1299    1301       +2     
=========================================
+ Hits        11531   11573      +42     
  Misses        922     922              
+ Partials      407     406       -1
Impacted Files Coverage Δ
saleor/graphql/payment/schema.py 100% <100%> (ø) ⬆️
saleor/graphql/payment/mutations.py 87.83% <90%> (+0.68%) ⬆️
saleor/payment/utils.py 97.72% <0%> (+2.27%) ⬆️
saleor/payment/gateways/dummy/__init__.py 100% <0%> (+4.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c010d06...0f45ec6. Read the comment docs.

@maarcingebala maarcingebala merged commit ad91ae8 into saleor:master Dec 14, 2018
@jxltom jxltom deleted the add-charge-payment-mutation branch December 14, 2018 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants