New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add warnings to order draft finalizing #3431
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3431 +/- ##
=======================================
Coverage 89.66% 89.66%
=======================================
Files 237 237
Lines 12854 12854
Branches 1299 1299
=======================================
Hits 11525 11525
Misses 922 922
Partials 407 407
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #3431 +/- ##
=========================================
Coverage ? 89.67%
=========================================
Files ? 237
Lines ? 12793
Branches ? 1285
=========================================
Hits ? 11472
Misses ? 920
Partials ? 401 Continue to review full report at Codecov.
|
@dominik-zeglen I've updated the schema for |
85baaed
to
a55ec26
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: Should the "CONFIRM" button be green if there's a warning displayed? Shouldn't the button be named after the action it performs ("FINALIZE")? In case of warnings, shouldn't we make it "danger" color and change the text to "FINALIZE ANYWAY"?
I'm +1 for the changes that @patrys mentioned. |
Okay, done |
Resolves #3405
Resolves #3440
Screenshots
Pull Request Checklist