Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warnings to order draft finalizing #3431

Merged
merged 11 commits into from Dec 13, 2018

Conversation

dominik-zeglen
Copy link
Contributor

@dominik-zeglen dominik-zeglen commented Dec 11, 2018

Resolves #3405
Resolves #3440

Screenshots

screenshot from 2018-12-11 11-58-32

Pull Request Checklist

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. Database migration files are up to date.
  6. The changes are tested.
  7. The code is documented (docstrings, project documentation).
  8. GraphQL schema and type definitions are up to date.
  9. Changes are mentioned in the changelog.

@codecov
Copy link

codecov bot commented Dec 11, 2018

Codecov Report

Merging #3431 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3431   +/-   ##
=======================================
  Coverage   89.66%   89.66%           
=======================================
  Files         237      237           
  Lines       12854    12854           
  Branches     1299     1299           
=======================================
  Hits        11525    11525           
  Misses        922      922           
  Partials      407      407
Impacted Files Coverage Δ
saleor/graphql/checkout/types.py 86.53% <ø> (ø) ⬆️
saleor/graphql/order/types.py 85.95% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecf9823...f426364. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 11, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@b799170). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3431   +/-   ##
=========================================
  Coverage          ?   89.67%           
=========================================
  Files             ?      237           
  Lines             ?    12793           
  Branches          ?     1285           
=========================================
  Hits              ?    11472           
  Misses            ?      920           
  Partials          ?      401

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b799170...c528313. Read the comment docs.

@maarcingebala
Copy link
Member

@dominik-zeglen I've updated the schema for canFinalize and isShippingRequired fields and regenerated the types.

patrys
patrys previously requested changes Dec 13, 2018
Copy link
Member

@patrys patrys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Should the "CONFIRM" button be green if there's a warning displayed? Shouldn't the button be named after the action it performs ("FINALIZE")? In case of warnings, shouldn't we make it "danger" color and change the text to "FINALIZE ANYWAY"?

@maarcingebala
Copy link
Member

I'm +1 for the changes that @patrys mentioned.

@dominik-zeglen
Copy link
Contributor Author

Okay, done

@maarcingebala maarcingebala dismissed patrys’s stale review December 13, 2018 15:52

Issue has been resolved.

@maarcingebala maarcingebala merged commit c010d06 into master Dec 13, 2018
@maarcingebala maarcingebala deleted the warn-if-finalizing-no-shipping branch December 13, 2018 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants