Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes #3433

Merged
merged 9 commits into from Dec 12, 2018
Merged

Minor fixes #3433

merged 9 commits into from Dec 12, 2018

Conversation

dominik-zeglen
Copy link
Contributor

@dominik-zeglen dominik-zeglen commented Dec 11, 2018

I want to merge this change because it fixes misplaced arrows in autocomplete fields, initial checkbox rendering, hid attributes section if product type has no product attributes and app crashing select fields.

Pull Request Checklist

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. Database migration files are up to date.
  6. The changes are tested.
  7. The code is documented (docstrings, project documentation).
  8. GraphQL schema and type definitions are up to date.
  9. Changes are mentioned in the changelog.

@codecov
Copy link

codecov bot commented Dec 11, 2018

Codecov Report

Merging #3433 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3433   +/-   ##
=======================================
  Coverage   89.67%   89.67%           
=======================================
  Files         237      237           
  Lines       12793    12793           
  Branches     1285     1285           
=======================================
  Hits        11472    11472           
  Misses        920      920           
  Partials      401      401

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77a71b7...0ed4760. Read the comment docs.

@maarcingebala
Copy link
Member

@dominik-zeglen Please update the changelog file as well.

Copy link
Member

@maarcingebala maarcingebala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've only tested the UI and the mentioned issues are resolved.

@maarcingebala maarcingebala merged commit b5994ce into master Dec 12, 2018
@maarcingebala maarcingebala deleted the minor-fixes branch December 12, 2018 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants