Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PermissionEnum as input parameter in staff mutations #3434

Merged
merged 3 commits into from Dec 12, 2018

Conversation

maarcingebala
Copy link
Member

@maarcingebala maarcingebala commented Dec 11, 2018

StaffCreateInput and StaffInput were using String as the input parameter while the PermissionEnum is the right one. Fixes crashing create/update views in Dashboard 2.0.

I've generated new types for TS and some unrelated types were changed, but I assume that we forgot to generate the new types with one of the previous PR so I kept that.

Pull Request Checklist

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. Database migration files are up to date.
  6. The changes are tested.
  7. The code is documented (docstrings, project documentation).
  8. GraphQL schema and type definitions are up to date.
  9. Changes are mentioned in the changelog.

@codecov
Copy link

codecov bot commented Dec 11, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@b799170). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3434   +/-   ##
=========================================
  Coverage          ?   89.67%           
=========================================
  Files             ?      237           
  Lines             ?    12793           
  Branches          ?     1285           
=========================================
  Hits              ?    11472           
  Misses            ?      920           
  Partials          ?      401
Impacted Files Coverage Δ
saleor/graphql/account/mutations.py 95.18% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b799170...2f2aa8d. Read the comment docs.

@maarcingebala maarcingebala merged commit 77a71b7 into saleor:master Dec 12, 2018
@maarcingebala maarcingebala deleted the fix-permissions-input branch December 12, 2018 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants