Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use autocomplete fields in country choice #3443

Merged
merged 16 commits into from Dec 17, 2018

Conversation

dominik-zeglen
Copy link
Contributor

@dominik-zeglen dominik-zeglen commented Dec 12, 2018

Resolves #3441

Pull Request Checklist

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. Database migration files are up to date.
  6. The changes are tested.
  7. The code is documented (docstrings, project documentation).
  8. GraphQL schema and type definitions are up to date.
  9. Changes are mentioned in the changelog.

@codecov
Copy link

codecov bot commented Dec 12, 2018

Codecov Report

Merging #3443 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3443   +/-   ##
=======================================
  Coverage   89.75%   89.75%           
=======================================
  Files         237      237           
  Lines       12943    12943           
  Branches     1312     1312           
=======================================
  Hits        11617    11617           
  Misses        922      922           
  Partials      404      404

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b87a29...f607cfa. Read the comment docs.

<DialogTitle>
{variant === "billing"
? i18n.t("Edit billing address", { context: "title" })
: i18n.t("Edit shipping address", { context: "title" })}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can simply toggle billing/shipping text

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@piotrgrundas Not really, those are translated and you need to translate entire sentences.

@maarcingebala maarcingebala merged commit 82f9257 into master Dec 17, 2018
@maarcingebala maarcingebala deleted the use-autocomplete-country branch December 17, 2018 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants