Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix decimal value argument in GraphQL #3457

Merged
merged 3 commits into from Dec 14, 2018

Conversation

fowczarek
Copy link
Member

@fowczarek fowczarek commented Dec 14, 2018

I want to merge this change because resolve #3428

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. Database migration files are up to date.
  6. The changes are tested.
  7. The code is documented (docstrings, project documentation).
  8. GraphQL schema and type definitions are up to date.
  9. Changes are mentioned in the changelog.

@fowczarek fowczarek self-assigned this Dec 14, 2018
@maarcingebala
Copy link
Member

We could also add a test for both cases:

  • passing decimal directly to query
  • passing it through variables

@codecov
Copy link

codecov bot commented Dec 14, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@3e6799e). Click here to learn what that means.
The diff coverage is 20%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3457   +/-   ##
=========================================
  Coverage          ?   89.73%           
=========================================
  Files             ?      237           
  Lines             ?    12943           
  Branches          ?     1312           
=========================================
  Hits              ?    11615           
  Misses            ?      924           
  Partials          ?      404
Impacted Files Coverage Δ
saleor/graphql/core/types/common.py 89.47% <20%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e6799e...4c61daf. Read the comment docs.

@maarcingebala maarcingebala merged commit 7f2ec04 into master Dec 14, 2018
@maarcingebala maarcingebala deleted the 3428/Fix_decimal_value_from_arguments branch December 14, 2018 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

productCreate and productUpdate mutations improperly validate decimal places
2 participants