Change filed type to choice field of tax rate in product

CHANGELOG.md

@@ -21,3 +21,4 @@ All notable, unreleased changes to this project will be documented in this file.
 - Support sorting products by update date - #3470 by @jxltom
 - Draft order should be able to clear its shipping method - #3472 by @fowczarek
 - Prefetch payment and payment transaction to optimize db queries - #3455 by @jxltom
+- Change filed type to choice field of tax rate in product - #3478 by @fowczarek

saleor/graphql/product/types.py

@@ -286,6 +286,7 @@ class Product(CountableDjangoObjectType):
         Money,
         description=dedent("""The product's base price (without any discounts
         applied)."""))
+    tax_rate = TaxRateType(description='A type of tax rate.')
     attributes = graphene.List(
         graphene.NonNull(SelectedAttribute), required=True,
         description='List of attributes assigned to this product.')

saleor/graphql/schema.graphql

@@ -1320,7 +1320,7 @@ type Product implements Node {
   attributes: [SelectedAttribute!]!
   updatedAt: DateTime
   chargeTaxes: Boolean!
-  taxRate: String!
+  taxRate: TaxRateType
   weight: Weight
   variants: [ProductVariant]
   images: [ProductImage]

saleor/product/models.py

@@ -129,7 +129,8 @@ class Product(SeoModel):
     updated_at = models.DateTimeField(auto_now=True, null=True)
     charge_taxes = models.BooleanField(default=True)
     tax_rate = models.CharField(
-        max_length=128, default=DEFAULT_TAX_RATE_NAME, blank=True)
+        max_length=128, default=DEFAULT_TAX_RATE_NAME, blank=True,
+        choices=TaxRateType.CHOICES)
     weight = MeasurementField(
         measurement=Weight, unit_choices=WeightUnits.CHOICES,
         blank=True, null=True)

tests/api/test_product.py

@@ -467,7 +467,7 @@ def test_create_product(
     assert data['product']['description'] == product_description
     assert data['product']['isPublished'] == product_is_published
     assert data['product']['chargeTaxes'] == product_charge_taxes
-    assert data['product']['taxRate'] == product_tax_rate.lower()
+    assert data['product']['taxRate'] == product_tax_rate
     assert data['product']['productType']['name'] == product_type.name
     assert data['product']['category']['name'] == category.name
     values = (
@@ -563,7 +563,7 @@ def test_update_product(
     assert data['product']['description'] == product_description
     assert data['product']['isPublished'] == product_isPublished
     assert data['product']['chargeTaxes'] == product_chargeTaxes
-    assert data['product']['taxRate'] == product_taxRate.lower()
+    assert data['product']['taxRate'] == product_taxRate
     assert not data['product']['category']['name'] == category.name