Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Elasticsearch from docker-compose #3482

Merged
merged 4 commits into from Dec 18, 2018

Conversation

maarcingebala
Copy link
Member

@maarcingebala maarcingebala commented Dec 18, 2018

We've decided to remove Elasticsearch from docker-compose in order to simplify the build on local machines. Elasticsearch is an optional dependency and should be configured manually if one needs to use it.

Fixes #3464

Pull Request Checklist

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. Database migration files are up to date.
  6. The changes are tested.
  7. The code is documented (docstrings, project documentation).
  8. GraphQL schema and type definitions are up to date.
  9. Changes are mentioned in the changelog.

@Pacu2
Copy link
Contributor

Pacu2 commented Dec 18, 2018

Do we have docs on how to set up elastic search?

@maarcingebala
Copy link
Member Author

@Pacu2 We recommend installing it in accordance with the official documentation.

@codecov
Copy link

codecov bot commented Dec 18, 2018

Codecov Report

Merging #3482 into master will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3482      +/-   ##
==========================================
- Coverage   89.87%   89.75%   -0.12%     
==========================================
  Files         241      237       -4     
  Lines       13103    12950     -153     
  Branches     1322     1313       -9     
==========================================
- Hits        11776    11623     -153     
  Misses        922      922              
  Partials      405      405
Impacted Files Coverage Δ
saleor/payment/gateways/stripe/forms.py
saleor/payment/gateways/stripe/utils.py
saleor/payment/gateways/stripe/errors.py
saleor/payment/gateways/stripe/__init__.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4aabaf...49a8dda. Read the comment docs.

@maarcingebala maarcingebala mentioned this pull request Dec 18, 2018
9 tasks
@maarcingebala maarcingebala merged commit ac74179 into saleor:master Dec 18, 2018
@maarcingebala maarcingebala deleted the remove-search-container branch December 18, 2018 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants