Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change mutation errors field from [Error] to [Error!] #3489

Merged
merged 3 commits into from Dec 19, 2018

Conversation

fowczarek
Copy link
Member

I want to merge this change because resolve #2746

Screenshots

Pull Request Checklist

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. Database migration files are up to date.
  6. The changes are tested.
  7. The code is documented (docstrings, project documentation).
  8. GraphQL schema and type definitions are up to date.
  9. Changes are mentioned in the changelog.

@fowczarek fowczarek changed the title 2746/change mutation errors field type Change mutation errors field from [Error] to [Error!] Dec 19, 2018
@fowczarek fowczarek self-assigned this Dec 19, 2018
@codecov
Copy link

codecov bot commented Dec 19, 2018

Codecov Report

Merging #3489 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3489   +/-   ##
=======================================
  Coverage   89.87%   89.87%           
=======================================
  Files         241      241           
  Lines       13103    13103           
  Branches     1322     1322           
=======================================
  Hits        11776    11776           
  Misses        922      922           
  Partials      405      405
Impacted Files Coverage Δ
saleor/graphql/core/mutations.py 92.68% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1bb298...0826a64. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 19, 2018

Codecov Report

Merging #3489 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3489   +/-   ##
=======================================
  Coverage   89.87%   89.87%           
=======================================
  Files         241      241           
  Lines       13103    13103           
  Branches     1322     1322           
=======================================
  Hits        11776    11776           
  Misses        922      922           
  Partials      405      405
Impacted Files Coverage Δ
saleor/graphql/core/mutations.py 92.68% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1bb298...f7bb3c8. Read the comment docs.

@maarcingebala
Copy link
Member

@dominik-zeglen How much does it affect Dashboard 2.0 code? Can we merge it or is your intervention required here?

@dominik-zeglen
Copy link
Contributor

I think we can get rid of (now) pointless checks if(data.something.errors === null "" data.something.errors.length === 0). Do it now?

@maarcingebala maarcingebala merged commit 1714cb9 into master Dec 19, 2018
@maarcingebala maarcingebala deleted the 2746/Change_mutation_errors_field_type branch December 19, 2018 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change mutation errors field from [Error] to [Error!]?
3 participants