Resolve to None when empty ID was passed #3497
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small improvement to the
get_node_or_error
function - if empty ID was passed as an argument it should immediately resolve toNone
. Without this change, multiple errors will be returned if empty String was passed as an ID to a mutation:Currently, if we pass an empty string as an ID argument in a mutation, it will result in two errors:
This PR changes this behavior to immediately return
None
in theget_node_or_error
function so that the actual object resolver is not fired. This will result in only one meaningful error:Edit: not related, but this PR also includes one minor TS types update, as it was out-of-date.
Pull Request Checklist