Refactor product selection dialogs

[dominik-zeglen]

Resolves #3487

Pull Request Checklist

1. Privileged views and APIs are guarded by proper permission checks.
2. All visible strings are translated with proper context.
3. All data-formatting is locale-aware (dates, numbers, and so on).
4. Database queries are optimized and the number of queries is constant.
5. Database migration files are up to date.
6. The changes are tested.
7. The code is documented (docstrings, project documentation).
8. GraphQL schema and type definitions are up to date.
9. Changes are mentioned in the changelog.

[codecov]

Codecov Report

Merging #3499 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3499   +/-   ##
=======================================
  Coverage   89.89%   89.89%           
=======================================
  Files         241      241           
  Lines       13109    13109           
  Branches     1323     1323           
=======================================
  Hits        11784    11784           
  Misses        921      921           
  Partials      404      404

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 989d5fb...78ee698. Read the comment docs.

[codecov]

Codecov Report

Merging #3499 into master will decrease coverage by <.01%.
The diff coverage is 90.32%.

@@            Coverage Diff             @@
##           master    #3499      +/-   ##
==========================================
- Coverage   89.84%   89.83%   -0.01%     
==========================================
  Files         250      250              
  Lines       13213    13217       +4     
  Branches     1337     1338       +1     
==========================================
+ Hits        11871    11874       +3     
  Misses        930      930              
- Partials      412      413       +1

Impacted Files	Coverage Δ
saleor/checkout/models.py	98.76% <100%> (ø)	⬆️
saleor/graphql/order/schema.py	100% <100%> (ø)	⬆️
saleor/page/models.py	92% <100%> (ø)	⬆️
saleor/menu/models.py	84.37% <100%> (ø)	⬆️
saleor/payment/models.py	97.32% <100%> (ø)	⬆️
saleor/order/models.py	90.43% <100%> (ø)	⬆️
saleor/graphql/product/types.py	97.11% <100%> (+0.01%)	⬆️
saleor/product/models.py	93.11% <100%> (+0.02%)	⬆️
saleor/graphql/order/mutations/draft_orders.py	92.48% <84.21%> (-0.41%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e45dfc...5a5df06. Read the comment docs.

[maarcingebala]

Worth sharing a screenshot of how our new and fancy product selection looks like:

[maarcingebala]

I've tested it and it looks and works great! One change that I'd suggest is to render a short message if no products were found.

[selvara80]

As well, good to have this at below as well Orders/Components/OrderProductAddDialog regards

…

On Fri, 21 Dec 2018 at 21:13, Marcin Gębala ***@***.***> wrote: I've tested it and it looks and works great! One change that I'd suggest is to render a short message if no products were found. [image: image] <https://user-images.githubusercontent.com/5421321/50350411-665d9b80-053f-11e9-8334-33869288adea.png> — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#3499 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AroYFcqiZ1U5V6u8vFSeSHHb9JWsROQEks5u7QGZgaJpZM4ZcDm9> .

[piotrgrundas]

You should really think about some code organizing. It's extremally hard to read IMO.

[maarcingebala]

True, for instances there are two large onChange handlers for checkboxes, shouldn't these be extracted to some functions for better readability?

[piotrgrundas]

You could extract functions etc to the top to make .jsx a lot clearer.