Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filtering attributes by collection #3508

Merged

Conversation

maarcingebala
Copy link
Member

@maarcingebala maarcingebala commented Dec 21, 2018

Fixes #3507

Pull Request Checklist

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. Database migration files are up to date.
  6. The changes are tested.
  7. The code is documented (docstrings, project documentation).
  8. GraphQL schema and type definitions are up to date.
  9. Changes are mentioned in the changelog.

@codecov
Copy link

codecov bot commented Dec 21, 2018

Codecov Report

Merging #3508 into master will decrease coverage by 0.01%.
The diff coverage is 72.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3508      +/-   ##
==========================================
- Coverage   89.89%   89.87%   -0.02%     
==========================================
  Files         241      241              
  Lines       13109    13119      +10     
  Branches     1323     1324       +1     
==========================================
+ Hits        11784    11791       +7     
- Misses        921      923       +2     
- Partials      404      405       +1
Impacted Files Coverage Δ
saleor/graphql/product/schema.py 100% <100%> (ø) ⬆️
saleor/graphql/product/resolvers.py 92.04% <66.66%> (-2.9%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1526e2...388de8b. Read the comment docs.

@maarcingebala maarcingebala merged commit 7109b84 into saleor:master Dec 27, 2018
@maarcingebala maarcingebala deleted the filter-attributes-by-collection branch December 27, 2018 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants