-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract enums #3523
Extract enums #3523
Conversation
@@ -2,27 +2,31 @@ | |||
from graphql_jwt.decorators import permission_required | |||
|
|||
from ..core.fields import PrefetchingConnectionField | |||
from ..descriptions import DESCRIPTIONS | |||
# FIXME: Types are imported before mutations on purpose. Otherwise these types |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if we imported these at the beginning of mutations.py
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could do that as well. Actually, I think there is no much difference - either here or there isort
will complain about the wrong order of imports. I have no idea why this happens, I spent one hour trying to debug it but found nothing.
Codecov Report
@@ Coverage Diff @@
## master #3523 +/- ##
==========================================
- Coverage 89.88% 89.86% -0.03%
==========================================
Files 241 250 +9
Lines 13120 13157 +37
Branches 1324 1326 +2
==========================================
+ Hits 11793 11823 +30
- Misses 922 927 +5
- Partials 405 407 +2
Continue to review full report at Codecov.
|
GraphQL maintenance - this PR extracts all enums to separate
enums.py
files within each graphql module. Also, I've moved some scalars to their own files.Pull Request Checklist