Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hard-coded site name in order PDFs #3526

Merged
merged 2 commits into from Jan 2, 2019

Conversation

NyanKiyoshi
Copy link
Member

@NyanKiyoshi NyanKiyoshi commented Dec 31, 2018

This replace the hard-coded Saleor eCommerce, Mirumee Software from the order PDFs stylesheet by the site name. This goes through a base PDF HTML template file containing the footer CSS code taking the data from the site settings.

Fixes #3510.

Pull Request Checklist

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. Database migration files are up to date.
  6. The changes are tested.
  7. The code is documented (docstrings, project documentation).
  8. GraphQL schema and type definitions are up to date.
  9. Changes are mentioned in the changelog.

@codecov
Copy link

codecov bot commented Dec 31, 2018

Codecov Report

Merging #3526 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3526      +/-   ##
==========================================
+ Coverage   89.87%   89.88%   +<.01%     
==========================================
  Files         241      241              
  Lines       13119    13120       +1     
  Branches     1324     1324              
==========================================
+ Hits        11791    11793       +2     
+ Misses        923      922       -1     
  Partials      405      405
Impacted Files Coverage Δ
saleor/dashboard/order/utils.py 93.9% <100%> (+0.07%) ⬆️
saleor/order/models.py 90.43% <0%> (+0.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7109b84...c075718. Read the comment docs.

@maarcingebala
Copy link
Member

@NyanKiyoshi Please update the changelog file.

@maarcingebala maarcingebala merged commit 9cc6cbe into saleor:master Jan 2, 2019
@NyanKiyoshi NyanKiyoshi deleted the fix/pdf-footers branch January 2, 2019 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants