Fix dependencies #3544
Merged
Fix dependencies #3544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3544 +/- ##
=======================================
Coverage 89.83% 89.83%
=======================================
Files 250 250
Lines 13207 13207
Branches 1334 1334
=======================================
Hits 11865 11865
Misses 930 930
Partials 412 412Continue to review full report at Codecov.
|
`awesome-typescript-loader` used to be the faster option but nowadays it seems not to be maintained any more.
dominik-zeglen
force-pushed
the
fix-dependencies
branch
from
1995293
to
e0aa0ca
Compare
patrys
reviewed
Jan 7, 2019
| @@ -44,3 +44,5 @@ All notable, unreleased changes to this project will be documented in this file. | |||
| - Add default variant create to Product mutations - #3505 by @fowczarek | |||
| - Fix attribute filters in parent category - #3535 by @fowczarek | |||
| - Fixed the no shipping orders payment crash on Stripe - #3550 by @NyanKiyoshi | |||
| - Change TypeScript loader to speed up the build process - #3545 by @patrys | |||
| - Fix storybook dependencies conflict - #3544 by @dominik-zeglen | |||
There was a problem hiding this comment.
Not sure if fixing deps needs a changelog entry, @maarcingebala?
patrys
approved these changes
Jan 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to merge this change because lately, we had some troubles setting up storybook and using
window.history.back(). This PR fixes these problems.Pull Request Checklist