Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch back to ts-loader #3545

Merged
merged 1 commit into from Jan 7, 2019
Merged

Switch back to ts-loader #3545

merged 1 commit into from Jan 7, 2019

Conversation

patrys
Copy link
Member

@patrys patrys commented Jan 4, 2019

awesome-typescript-loader used to be the faster option but nowadays it seems not to be maintained any more.

Local performance benchmark:

Loader Cold cache Warm cache
ts-loader 35s 15s
awesome-typescript-loader 44s 23s

Pull Request Checklist

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. Database migration files are up to date.
  6. The changes are tested.
  7. The code is documented (docstrings, project documentation).
  8. GraphQL schema and type definitions are up to date.
  9. Changes are mentioned in the changelog.

@patrys
Copy link
Member Author

patrys commented Jan 4, 2019

@dominik-zeglen Please compare the execution time on your machine.

@codecov
Copy link

codecov bot commented Jan 4, 2019

Codecov Report

Merging #3545 into fix-dependencies will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           fix-dependencies    #3545   +/-   ##
=================================================
  Coverage             89.82%   89.82%           
=================================================
  Files                   250      250           
  Lines                 13194    13194           
  Branches               1333     1333           
=================================================
  Hits                  11852    11852           
  Misses                  930      930           
  Partials                412      412

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8069c9a...973ddd9. Read the comment docs.

@dominik-zeglen dominik-zeglen changed the base branch from master to fix-dependencies January 4, 2019 14:12
`awesome-typescript-loader` used to be the faster option but nowadays
it seems not to be maintained any more.
@dominik-zeglen dominik-zeglen merged this pull request into saleor:fix-dependencies Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants