Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use always the newest GraphQL playground version #3971

Merged
merged 2 commits into from Apr 19, 2019

Conversation

salwator
Copy link
Contributor

@salwator salwator commented Apr 15, 2019

I want to merge this change because...

Current version of playground in saleor is hardcoded to 1.7.8. We should use newer (1.8) instead, preferably refer to newest version on CDN.

One important feature available in newer version is browsing schema through dedicated playground menu.

Pull Request Checklist

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. Database migration files are up to date.
  6. The changes are tested.
  7. The code is documented (docstrings, project documentation).
  8. GraphQL schema and type definitions are up to date.
  9. Changes are mentioned in the changelog.

@salwator salwator requested a review from patrys April 15, 2019 14:58
@salwator salwator added the graphql Issues related to the GraphQL API label Apr 15, 2019
@codecov
Copy link

codecov bot commented Apr 15, 2019

Codecov Report

Merging #3971 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3971   +/-   ##
=======================================
  Coverage   91.29%   91.29%           
=======================================
  Files         267      267           
  Lines       14508    14508           
  Branches     1395     1395           
=======================================
  Hits        13245    13245           
  Misses        894      894           
  Partials      369      369

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 486e271...b90f526. Read the comment docs.

@maarcingebala
Copy link
Member

@salwator Thanks for opening this PR! Can you please update the changelog file as well?

@salwator salwator force-pushed the use_fresh_graphql_playground branch from b1d802d to b90f526 Compare April 19, 2019 08:25
@salwator salwator changed the title Use always newest graphql playground version Use always the newest GraphQL playground version Apr 19, 2019
@maarcingebala maarcingebala merged commit cb312fa into master Apr 19, 2019
@maarcingebala maarcingebala deleted the use_fresh_graphql_playground branch April 19, 2019 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
graphql Issues related to the GraphQL API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants