New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Styled file field with materializecss template filter #3998
Conversation
Hi, I already proposed this change in #3690 but I moved to another branch in order to submit more PRs. I would appreciate an answer about this little contribution. 😄 |
82ebcfa
to
ab670f9
Compare
Codecov Report
@@ Coverage Diff @@
## master #3998 +/- ##
=======================================
Coverage 91.29% 91.29%
=======================================
Files 267 267
Lines 14508 14508
Branches 1395 1395
=======================================
Hits 13245 13245
Misses 894 894
Partials 369 369 Continue to review full report at Codecov.
|
ab670f9
to
7659e2d
Compare
I updated this PR with the latest commit in master branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me and it works great!
Don't forget to update the changelog!
Hi, @NyanKiyoshi I have updated the change log |
@zodiacfireworks Congrats on your first PR to Saleor! 🎉 |
❤️ Thanks! @maarcingebala, @NyanKiyoshi |
I want to merge this change because in some places of the dashboard we have file fields with material style. But in other places we have an ugly browser based file field. With this little PR we will have file fields with material style using the template filter materializecss.
Screenshots
Picture from product image form:
Picture from category form:
Picture from category form after changes:
Pull Request Checklist