Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styled file field with materializecss template filter #3998

Merged
merged 2 commits into from Apr 24, 2019

Conversation

zodiacfireworks
Copy link
Contributor

@zodiacfireworks zodiacfireworks commented Apr 20, 2019

I want to merge this change because in some places of the dashboard we have file fields with material style. But in other places we have an ugly browser based file field. With this little PR we will have file fields with material style using the template filter materializecss.

Screenshots

Picture from product image form:
image

Picture from category form:
image

Picture from category form after changes:
image

Pull Request Checklist

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. Database migration files are up to date.
  6. The changes are tested.
  7. The code is documented (docstrings, project documentation).
  8. GraphQL schema and type definitions are up to date.
  9. Changes are mentioned in the changelog.

@zodiacfireworks
Copy link
Contributor Author

Hi, I already proposed this change in #3690 but I moved to another branch in order to submit more PRs.

I would appreciate an answer about this little contribution. 😄

@codecov
Copy link

codecov bot commented Apr 20, 2019

Codecov Report

Merging #3998 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3998   +/-   ##
=======================================
  Coverage   91.29%   91.29%           
=======================================
  Files         267      267           
  Lines       14508    14508           
  Branches     1395     1395           
=======================================
  Hits        13245    13245           
  Misses        894      894           
  Partials      369      369

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb312fa...cf57255. Read the comment docs.

@zodiacfireworks
Copy link
Contributor Author

I updated this PR with the latest commit in master branch

Copy link
Member

@NyanKiyoshi NyanKiyoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and it works great!

Don't forget to update the changelog!

@zodiacfireworks
Copy link
Contributor Author

Hi, @NyanKiyoshi

I have updated the change log

@maarcingebala maarcingebala merged commit d0ba739 into saleor:master Apr 24, 2019
@maarcingebala
Copy link
Member

@zodiacfireworks Congrats on your first PR to Saleor! 🎉

@zodiacfireworks
Copy link
Contributor Author

zodiacfireworks commented Apr 25, 2019

❤️ Thanks! @maarcingebala, @NyanKiyoshi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants