Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict single payment resolving #4009

Conversation

NyanKiyoshi
Copy link
Member

@NyanKiyoshi NyanKiyoshi commented Apr 24, 2019

Fix a missing permission check.

Pull Request Checklist

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. Database migration files are up to date.
  6. The changes are tested.
  7. The code is documented (docstrings, project documentation).
  8. GraphQL schema and type definitions are up to date.
  9. Changes are mentioned in the changelog.

@NyanKiyoshi NyanKiyoshi added bug graphql Issues related to the GraphQL API labels Apr 24, 2019
@NyanKiyoshi NyanKiyoshi self-assigned this Apr 24, 2019
@NyanKiyoshi NyanKiyoshi force-pushed the gql/fix/getting-single-payment-restriction branch from 81866ca to 16a0abd Compare April 24, 2019 11:38
@NyanKiyoshi NyanKiyoshi force-pushed the gql/fix/getting-single-payment-restriction branch from 16a0abd to 2d10a2c Compare April 24, 2019 11:38
@codecov
Copy link

codecov bot commented Apr 24, 2019

Codecov Report

Merging #4009 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4009   +/-   ##
=======================================
  Coverage   91.27%   91.27%           
=======================================
  Files         275      275           
  Lines       14953    14953           
  Branches     1448     1448           
=======================================
  Hits        13649    13649           
  Misses        913      913           
  Partials      391      391
Impacted Files Coverage Δ
saleor/graphql/payment/schema.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49b7080...2d10a2c. Read the comment docs.

@maarcingebala maarcingebala merged commit 8182cc1 into saleor:master Apr 24, 2019
@NyanKiyoshi NyanKiyoshi deleted the gql/fix/getting-single-payment-restriction branch April 24, 2019 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug graphql Issues related to the GraphQL API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants