Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dataclasses as a structure for payment's gateways #4028

Merged
merged 18 commits into from May 6, 2019
Merged

Use dataclasses as a structure for payment's gateways #4028

merged 18 commits into from May 6, 2019

Conversation

korycins
Copy link
Member

@korycins korycins added the payments Issues related to payments implementation label Apr 25, 2019
@korycins korycins self-assigned this Apr 25, 2019
Copy link
Member

@NyanKiyoshi NyanKiyoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the payment_information: Dict? Is it planned or?

It's generated by this:
https://github.com/mirumee/saleor/blob/d54ab16024d55f78ce2c4a7cf014f02952b5a9dd/saleor/payment/utils.py#L48-L68

Pipfile Outdated Show resolved Hide resolved
@codecov

This comment has been minimized.

@NyanKiyoshi

This comment has been minimized.

@saleor saleor deleted a comment from codecov bot Apr 27, 2019
@NyanKiyoshi NyanKiyoshi self-assigned this Apr 30, 2019
@codecov
Copy link

codecov bot commented Apr 30, 2019

Codecov Report

Merging #4028 into master will decrease coverage by 0.09%.
The diff coverage is 97.45%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #4028     +/-   ##
=========================================
- Coverage   91.37%   91.28%   -0.1%     
=========================================
  Files         274      276      +2     
  Lines       14947    14975     +28     
  Branches     1451     1445      -6     
=========================================
+ Hits        13658    13670     +12     
- Misses        898      913     +15     
- Partials      391      392      +1
Impacted Files Coverage Δ
saleor/payment/gateways/stripe/forms.py 96.66% <100%> (+0.23%) ⬆️
saleor/payment/gateways/razorpay/forms.py 96.96% <100%> (+0.09%) ⬆️
saleor/payment/gateways/braintree/__init__.py 100% <100%> (ø) ⬆️
saleor/payment/interface.py 100% <100%> (ø)
saleor/payment/gateways/razorpay/__init__.py 98.5% <100%> (+0.02%) ⬆️
saleor/payment/gateways/braintree/forms.py 95% <100%> (+0.26%) ⬆️
saleor/payment/gateways/stripe/__init__.py 98.95% <100%> (+0.01%) ⬆️
saleor/payment/gateways/stripe/utils.py 100% <100%> (ø) ⬆️
saleor/payment/gateways/dummy/__init__.py 100% <100%> (ø) ⬆️
saleor/payment/utils.py 92.13% <87.5%> (-0.72%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b83a0eb...3da9f98. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 30, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@0c22560). Click here to learn what that means.
The diff coverage is 97.69%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4028   +/-   ##
=========================================
  Coverage          ?   91.32%           
=========================================
  Files             ?      275           
  Lines             ?    14958           
  Branches          ?     1448           
=========================================
  Hits              ?    13660           
  Misses            ?      904           
  Partials          ?      394
Impacted Files Coverage Δ
saleor/payment/gateways/stripe/forms.py 96.66% <100%> (ø)
saleor/payment/gateways/razorpay/forms.py 96.87% <100%> (ø)
saleor/payment/gateways/braintree/__init__.py 100% <100%> (ø)
saleor/payment/interface.py 100% <100%> (ø)
saleor/payment/gateways/razorpay/__init__.py 98.5% <100%> (ø)
saleor/payment/gateways/braintree/forms.py 95% <100%> (ø)
saleor/payment/gateways/stripe/__init__.py 98.95% <100%> (ø)
saleor/payment/gateways/stripe/utils.py 100% <100%> (ø)
saleor/payment/gateways/dummy/__init__.py 100% <100%> (ø)
saleor/payment/utils.py 92.13% <87.5%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c22560...a746c40. Read the comment docs.

Pipfile Outdated Show resolved Hide resolved
@michaljelonek
Copy link
Contributor

Also I would personally add removing support for 3.5 as a separate changelog entry. I realise you can deduce that by the word dataclass, but imo it's implied and not really that obvious, I think being explicit here for such change would be better.

docs/guides/payments.rst Outdated Show resolved Hide resolved
docs/guides/payments.rst Outdated Show resolved Hide resolved
docs/guides/payments.rst Outdated Show resolved Hide resolved
docs/guides/payments.rst Outdated Show resolved Hide resolved
docs/guides/payments.rst Outdated Show resolved Hide resolved
docs/guides/payments.rst Outdated Show resolved Hide resolved
docs/guides/payments.rst Outdated Show resolved Hide resolved
docs/guides/payments.rst Outdated Show resolved Hide resolved
docs/guides/payments.rst Outdated Show resolved Hide resolved
docs/guides/payments.rst Outdated Show resolved Hide resolved
@NyanKiyoshi NyanKiyoshi removed their assignment May 6, 2019
@maarcingebala maarcingebala merged commit d762451 into saleor:master May 6, 2019
@korycins korycins deleted the use_better_datastructure_for_payment_gateways branch October 22, 2019 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
payments Issues related to payments implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants