New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use dataclasses as a structure for payment's gateways #4028
Use dataclasses as a structure for payment's gateways #4028
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about the payment_information: Dict
? Is it planned or?
It's generated by this:
https://github.com/mirumee/saleor/blob/d54ab16024d55f78ce2c4a7cf014f02952b5a9dd/saleor/payment/utils.py#L48-L68
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## master #4028 +/- ##
=========================================
- Coverage 91.37% 91.28% -0.1%
=========================================
Files 274 276 +2
Lines 14947 14975 +28
Branches 1451 1445 -6
=========================================
+ Hits 13658 13670 +12
- Misses 898 913 +15
- Partials 391 392 +1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #4028 +/- ##
=========================================
Coverage ? 91.32%
=========================================
Files ? 275
Lines ? 14958
Branches ? 1448
=========================================
Hits ? 13660
Misses ? 904
Partials ? 394
Continue to review full report at Codecov.
|
Also I would personally add removing support for 3.5 as a separate changelog entry. I realise you can deduce that by the word |
#3678