Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user avatar management #4030

Merged
merged 16 commits into from May 6, 2019
Merged

Add user avatar management #4030

merged 16 commits into from May 6, 2019

Conversation

benekex2
Copy link
Contributor

@benekex2 benekex2 commented Apr 26, 2019

I want to merge this change because its add user avatar managment

Resolves #3921

Screenshots

Pull Request Checklist

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. Database migration files are up to date.
  6. The changes are tested.
  7. The code is documented (docstrings, project documentation).
  8. GraphQL schema and type definitions are up to date.
  9. Changes are mentioned in the changelog.

@benekex2 benekex2 marked this pull request as ready for review April 29, 2019 13:41
@codecov

This comment has been minimized.

@codecov
Copy link

codecov bot commented Apr 29, 2019

Codecov Report

Merging #4030 into master will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4030      +/-   ##
==========================================
+ Coverage   91.28%   91.37%   +0.09%     
==========================================
  Files         275      274       -1     
  Lines       14955    14947       -8     
  Branches     1450     1451       +1     
==========================================
+ Hits        13651    13658       +7     
+ Misses        913      898      -15     
  Partials      391      391
Impacted Files Coverage Δ
saleor/graphql/core/decorators.py
saleor/graphql/checkout/mutations.py 93.42% <0%> (+0.06%) ⬆️
saleor/checkout/forms.py 96.02% <0%> (+0.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c916cb2...d4b0261. Read the comment docs.

@maarcingebala maarcingebala merged commit 0c22560 into master May 6, 2019
@maarcingebala maarcingebala deleted the add-user-avatar-managment branch May 6, 2019 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to change user's avatar
3 participants