Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix product listing not showing in the voucher form #4062

Conversation

NyanKiyoshi
Copy link
Member

Closes #4060.

Pull Request Checklist

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. Database migration files are up to date.
  6. The changes are tested.
  7. The code is documented (docstrings, project documentation).
  8. GraphQL schema and type definitions are up to date.
  9. Changes are mentioned in the changelog.

@NyanKiyoshi NyanKiyoshi force-pushed the dashboard-1.0/fix/voucher-form/product-listing branch from ba4c96d to 7d94d80 Compare May 4, 2019 18:33
@NyanKiyoshi NyanKiyoshi self-assigned this May 4, 2019
@codecov
Copy link

codecov bot commented May 4, 2019

Codecov Report

Merging #4062 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4062      +/-   ##
==========================================
- Coverage   91.32%   91.31%   -0.01%     
==========================================
  Files         275      274       -1     
  Lines       14958    14931      -27     
  Branches     1448     1453       +5     
==========================================
- Hits        13660    13634      -26     
  Misses        904      904              
+ Partials      394      393       -1
Impacted Files Coverage Δ
saleor/dashboard/discount/forms.py 93.33% <100%> (+0.31%) ⬆️
saleor/payment/gateways/braintree/forms.py 94.73% <0%> (-0.27%) ⬇️
saleor/payment/gateways/stripe/forms.py 96.42% <0%> (-0.24%) ⬇️
saleor/payment/gateways/razorpay/__init__.py 98.48% <0%> (-0.03%) ⬇️
saleor/payment/gateways/stripe/__init__.py 98.94% <0%> (-0.02%) ⬇️
saleor/payment/gateways/braintree/__init__.py 100% <0%> (ø) ⬆️
saleor/payment/gateways/stripe/utils.py 100% <0%> (ø) ⬆️
saleor/payment/gateways/razorpay/forms.py 96.87% <0%> (ø) ⬆️
saleor/payment/gateways/dummy/__init__.py 100% <0%> (ø) ⬆️
saleor/payment/interface.py
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d762451...78fe52a. Read the comment docs.

@maarcingebala maarcingebala merged commit 3074663 into saleor:master May 6, 2019
@NyanKiyoshi NyanKiyoshi deleted the dashboard-1.0/fix/voucher-form/product-listing branch May 6, 2019 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The voucher form doesn't show selected products
3 participants