Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update order events and order email events names in typescripts #4089

Merged
merged 7 commits into from May 9, 2019

Conversation

jxltom
Copy link
Contributor

@jxltom jxltom commented May 9, 2019

It looks like #4018 didn't update the typescripts with updated order events and order email events, this PR fixes this issue.

This PR also remove gql-types.ts since it is replaced by globalTypes.ts and is not used anymore.

Pull Request Checklist

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. Database migration files are up to date.
  6. The changes are tested.
  7. The code is documented (docstrings, project documentation).
  8. GraphQL schema and type definitions are up to date.
  9. Changes are mentioned in the changelog.

@codecov
Copy link

codecov bot commented May 9, 2019

Codecov Report

Merging #4089 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4089   +/-   ##
=======================================
  Coverage   91.56%   91.56%           
=======================================
  Files         277      277           
  Lines       15106    15106           
  Branches     1474     1474           
=======================================
  Hits        13832    13832           
  Misses        877      877           
  Partials      397      397

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc45dd7...55df097. Read the comment docs.

…derHistory.tsx

Co-Authored-By: Marcin Gębala <5421321+maarcingebala@users.noreply.github.com>
@maarcingebala maarcingebala merged commit 3959599 into saleor:master May 9, 2019
@jxltom jxltom deleted the update-typescript-types branch May 9, 2019 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants