Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos and messages system tense #4168

Merged
merged 6 commits into from May 28, 2019

Conversation

benekex2
Copy link
Contributor

Resolves #4129

I want to merge this change because...

Screenshots

Pull Request Checklist

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. Database migration files are up to date.
  6. The changes are tested.
  7. The code is documented (docstrings, project documentation).
  8. GraphQL schema and type definitions are up to date.
  9. Changes are mentioned in the changelog.

@codecov
Copy link

codecov bot commented May 28, 2019

Codecov Report

Merging #4168 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4168      +/-   ##
==========================================
+ Coverage    91.7%   91.72%   +0.01%     
==========================================
  Files         278      278              
  Lines       15485    15485              
  Branches     1506     1506              
==========================================
+ Hits        14201    14203       +2     
+ Misses        882      881       -1     
+ Partials      402      401       -1
Impacted Files Coverage Δ
saleor/payment/utils.py 91.5% <0%> (+0.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f552aef...15ab710. Read the comment docs.

@maarcingebala maarcingebala merged commit 802b9a6 into master May 28, 2019
@maarcingebala maarcingebala deleted the fix-typos-and-messages-system-tense branch May 28, 2019 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix typos and change wording in Dashboard 2.0 system messages
3 participants