Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change voucher types #4344

Merged
merged 15 commits into from
Jul 1, 2019
Merged

Change voucher types #4344

merged 15 commits into from
Jul 1, 2019

Conversation

fowczarek
Copy link
Member

I want to merge this change because, resolve #4317

Screenshots

Pull Request Checklist

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. Database migration files are up to date.
  6. The changes are tested.
  7. The code is documented (docstrings, project documentation).
  8. GraphQL schema and type definitions are up to date.
  9. Changes are mentioned in the changelog.

@fowczarek fowczarek added in progress dashboard 1.0 graphql Issues related to the GraphQL API labels Jun 25, 2019
@fowczarek fowczarek self-assigned this Jun 25, 2019
@fowczarek fowczarek changed the title 4317/change voucher types Change voucher types Jun 25, 2019
Copy link
Member

@NyanKiyoshi NyanKiyoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you planning on adding a migration?

tests/api/test_discount.py Outdated Show resolved Hide resolved
@fowczarek
Copy link
Member Author

Are you planning on adding a migration?

This pull request has "In progress" label. I adding migrations after final rebase.

@codecov
Copy link

codecov bot commented Jun 28, 2019

Codecov Report

Merging #4344 into master will increase coverage by <.01%.
The diff coverage is 94.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4344      +/-   ##
==========================================
+ Coverage   91.96%   91.97%   +<.01%     
==========================================
  Files         285      285              
  Lines       15911    15945      +34     
  Branches     1547     1553       +6     
==========================================
+ Hits        14633    14665      +32     
- Misses        873      874       +1     
- Partials      405      406       +1
Impacted Files Coverage Δ
saleor/dashboard/discount/views.py 72.64% <ø> (ø) ⬆️
saleor/discount/models.py 83.6% <ø> (ø) ⬆️
saleor/dashboard/order/utils.py 93.42% <100%> (ø) ⬆️
saleor/graphql/discount/mutations.py 98.18% <100%> (+0.03%) ⬆️
saleor/graphql/discount/enums.py 100% <100%> (ø) ⬆️
saleor/dashboard/discount/forms.py 98.05% <100%> (+0.28%) ⬆️
saleor/checkout/utils.py 83.33% <88.88%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63f77c5...c4f2c25. Read the comment docs.

Copy link

django-queries commented Jun 28, 2019

Here is the report for c4f2c25 (mirumee/saleor @ 4317/change_voucher_types)
Base comparison is 63f77c5.

No differences were found. (click me)

# api.benchmark checkout
  test name                           	left count 	right count
  ------------------------------------	-----------	-----------
  add billing address to checkout     	         41	         41
  add shipping to checkout            	          7	          7
  checkout payment charge             	         16	         16
  complete checkout                   	          6	          6
  create checkout                     	         45	         45

# api.benchmark homepage
  test name                           	left count 	right count
  ------------------------------------	-----------	-----------
  retrieve main menu                  	          5	          5
  retrieve product list               	          4	          4
  retrieve secondary menu             	          5	          5
  retrieve shop                       	          2	          2

# api.benchmark product
  test name                           	left count 	right count
  ------------------------------------	-----------	-----------
  product details                     	         13	         13

# api.benchmark variant
  test name                           	left count 	right count
  ------------------------------------	-----------	-----------
  retrieve variant list               	          9	          9

Copy link
Member

@NyanKiyoshi NyanKiyoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to migrate the discounts having VALUE to ENTIRE_ORDER

saleor/dashboard/discount/forms.py Outdated Show resolved Hide resolved
saleor/dashboard/discount/forms.py Outdated Show resolved Hide resolved
saleor/dashboard/discount/forms.py Outdated Show resolved Hide resolved
saleor/dashboard/discount/forms.py Show resolved Hide resolved
saleor/dashboard/discount/forms.py Show resolved Hide resolved
saleor/discount/__init__.py Show resolved Hide resolved
saleor/graphql/discount/mutations.py Outdated Show resolved Hide resolved
saleor/graphql/discount/mutations.py Outdated Show resolved Hide resolved
saleor/graphql/schema.graphql Show resolved Hide resolved
@fowczarek fowczarek force-pushed the 4317/change_voucher_types branch 2 times, most recently from a9adaee to e5b5b72 Compare July 1, 2019 08:54
@korycins korycins merged commit a592e13 into master Jul 1, 2019
@korycins korycins deleted the 4317/change_voucher_types branch July 1, 2019 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
graphql Issues related to the GraphQL API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change voucher types for new dashboard layout
4 participants