-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change voucher types #4344
Change voucher types #4344
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you planning on adding a migration?
This pull request has "In progress" label. I adding migrations after final rebase. |
6b6d4eb
to
0e16f52
Compare
0e16f52
to
fd8c2cd
Compare
Codecov Report
@@ Coverage Diff @@
## master #4344 +/- ##
==========================================
+ Coverage 91.96% 91.97% +<.01%
==========================================
Files 285 285
Lines 15911 15945 +34
Branches 1547 1553 +6
==========================================
+ Hits 14633 14665 +32
- Misses 873 874 +1
- Partials 405 406 +1
Continue to review full report at Codecov.
|
Here is the report for c4f2c25 (mirumee/saleor @ 4317/change_voucher_types) No differences were found. (click me)
# api.benchmark checkout
test name left count right count
------------------------------------ ----------- -----------
add billing address to checkout 41 41
add shipping to checkout 7 7
checkout payment charge 16 16
complete checkout 6 6
create checkout 45 45
# api.benchmark homepage
test name left count right count
------------------------------------ ----------- -----------
retrieve main menu 5 5
retrieve product list 4 4
retrieve secondary menu 5 5
retrieve shop 2 2
# api.benchmark product
test name left count right count
------------------------------------ ----------- -----------
product details 13 13
# api.benchmark variant
test name left count right count
------------------------------------ ----------- -----------
retrieve variant list 9 9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to migrate the discounts having VALUE
to ENTIRE_ORDER
a9adaee
to
e5b5b72
Compare
e5b5b72
to
3dfe898
Compare
3dfe898
to
c4f2c25
Compare
I want to merge this change because, resolve #4317
Screenshots
Pull Request Checklist