-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use esModuleInterop #4372
Use esModuleInterop #4372
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4372 +/- ##
=======================================
Coverage 91.97% 91.97%
=======================================
Files 285 285
Lines 15945 15945
Branches 1553 1553
=======================================
Hits 14665 14665
Misses 874 874
Partials 406 406 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #4372 +/- ##
=======================================
Coverage 91.97% 91.97%
=======================================
Files 285 285
Lines 15945 15945
Branches 1553 1553
=======================================
Hits 14665 14665
Misses 874 874
Partials 406 406 Continue to review full report at Codecov.
|
Here is the report for c20483e (mirumee/saleor @ use-es-module-interop) No differences were found. (click me)
# api.benchmark checkout
test name left count right count duplicate count
------------------------------------ ----------- ----------- ---------------
add billing address to checkout 41 41 24
add shipping to checkout 7 7 0
checkout payment charge 16 16 0
complete checkout 6 6 0
create checkout 45 45 21
# api.benchmark homepage
test name left count right count duplicate count
------------------------------------ ----------- ----------- ---------------
retrieve main menu 5 5 0
retrieve product list 4 4 0
retrieve secondary menu 5 5 0
retrieve shop 2 2 0
# api.benchmark product
test name left count right count duplicate count
------------------------------------ ----------- ----------- ---------------
product details 13 13 3
# api.benchmark variant
test name left count right count duplicate count
------------------------------------ ----------- ----------- ---------------
retrieve variant list 9 9 2 |
b643fb1
to
c20483e
Compare
I want to merge this change because it simplifies imports and allows to use lodash submodules.
Pull Request Checklist