Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use esModuleInterop #4372

Merged
merged 4 commits into from
Jul 2, 2019
Merged

Use esModuleInterop #4372

merged 4 commits into from
Jul 2, 2019

Conversation

dominik-zeglen
Copy link
Contributor

I want to merge this change because it simplifies imports and allows to use lodash submodules.

Pull Request Checklist

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. Database migration files are up to date.
  6. The changes are tested.
  7. The code is documented (docstrings, project documentation).
  8. GraphQL schema and type definitions are up to date.
  9. Changes are mentioned in the changelog.

@codecov
Copy link

codecov bot commented Jul 2, 2019

Codecov Report

Merging #4372 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4372   +/-   ##
=======================================
  Coverage   91.97%   91.97%           
=======================================
  Files         285      285           
  Lines       15945    15945           
  Branches     1553     1553           
=======================================
  Hits        14665    14665           
  Misses        874      874           
  Partials      406      406

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71ccf89...941ba61. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 2, 2019

Codecov Report

Merging #4372 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4372   +/-   ##
=======================================
  Coverage   91.97%   91.97%           
=======================================
  Files         285      285           
  Lines       15945    15945           
  Branches     1553     1553           
=======================================
  Hits        14665    14665           
  Misses        874      874           
  Partials      406      406

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71ccf89...c20483e. Read the comment docs.

Copy link

django-queries commented Jul 2, 2019

Here is the report for c20483e (mirumee/saleor @ use-es-module-interop)
Base comparison is 71ccf89.

No differences were found. (click me)

# api.benchmark checkout
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  add billing address to checkout     	         41	         41	             24
  add shipping to checkout            	          7	          7	              0
  checkout payment charge             	         16	         16	              0
  complete checkout                   	          6	          6	              0
  create checkout                     	         45	         45	             21

# api.benchmark homepage
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  retrieve main menu                  	          5	          5	              0
  retrieve product list               	          4	          4	              0
  retrieve secondary menu             	          5	          5	              0
  retrieve shop                       	          2	          2	              0

# api.benchmark product
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  product details                     	         13	         13	              3

# api.benchmark variant
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  retrieve variant list               	          9	          9	              2

@dominik-zeglen dominik-zeglen mentioned this pull request Jul 2, 2019
9 tasks
@dominik-zeglen dominik-zeglen merged commit 415f84e into master Jul 2, 2019
@dominik-zeglen dominik-zeglen deleted the use-es-module-interop branch July 2, 2019 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants