Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/failing times asserts in test discount #4401

Merged
merged 3 commits into from
Jul 5, 2019

Conversation

korycins
Copy link
Member

@korycins korycins commented Jul 5, 2019

Quick fix for random failing tests from test_discount

@korycins korycins requested a review from NyanKiyoshi July 5, 2019 08:33
@korycins korycins self-assigned this Jul 5, 2019
Copy link

django-queries commented Jul 5, 2019

Here is the report for 298a8fb (mirumee/saleor @ fix/failing_times_asserts_in_test_discount)
Base comparison is 9dd1474.

No differences were found. (click me)

# api.benchmark checkout
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  add billing address to checkout     	         34	         34	             20
  add shipping to checkout            	          7	          7	              0
  checkout payment charge             	         14	         14	              0
  complete checkout                   	          6	          6	              0
  create checkout                     	         43	         43	             21

# api.benchmark homepage
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  retrieve main menu                  	          5	          5	              0
  retrieve product list               	          4	          4	              0
  retrieve secondary menu             	          5	          5	              0
  retrieve shop                       	          2	          2	              0

# api.benchmark product
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  product details                     	         13	         13	              3

# api.benchmark variant
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  retrieve variant list               	          9	          9	              2

@codecov
Copy link

codecov bot commented Jul 5, 2019

Codecov Report

Merging #4401 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4401      +/-   ##
=========================================
- Coverage   90.71%   90.7%   -0.02%     
=========================================
  Files         291     291              
  Lines       16679   16679              
  Branches     1691    1691              
=========================================
- Hits        15131   15129       -2     
- Misses       1053    1054       +1     
- Partials      495     496       +1
Impacted Files Coverage Δ
saleor/payment/utils.py 91.07% <0%> (-0.94%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dd1474...298a8fb. Read the comment docs.

@NyanKiyoshi
Copy link
Member

c.f. #4397

@NyanKiyoshi NyanKiyoshi merged commit 04fc905 into master Jul 5, 2019
@NyanKiyoshi NyanKiyoshi deleted the fix/failing_times_asserts_in_test_discount branch July 5, 2019 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants