Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix internal error when users enters an invalid phone number in an address #4404

Merged
merged 1 commit into from
Jul 5, 2019

Conversation

NyanKiyoshi
Copy link
Member

Fixes #4393.

Pull Request Checklist

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. Database migration files are up to date.
  6. The changes are tested.
  7. The code is documented (docstrings, project documentation).
  8. GraphQL schema and type definitions are up to date.
  9. Changes are mentioned in the changelog.

@NyanKiyoshi NyanKiyoshi added the bug label Jul 5, 2019
@NyanKiyoshi NyanKiyoshi requested a review from korycins July 5, 2019 11:34
@NyanKiyoshi NyanKiyoshi self-assigned this Jul 5, 2019
@NyanKiyoshi NyanKiyoshi changed the title Fix invalid call in the payment migrations Fix internal error when users enters an invalid phone number in an address Jul 5, 2019
Copy link

django-queries commented Jul 5, 2019

Here is the report for fd1af81 (NyanKiyoshi/saleor @ accounts/phones/validations)
Base comparison is 04fc905.

No differences were found. (click me)

# api.benchmark checkout
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  add billing address to checkout     	         34	         34	             20
  add shipping to checkout            	          7	          7	              0
  checkout payment charge             	         14	         14	              0
  complete checkout                   	          6	          6	              0
  create checkout                     	         43	         43	             21

# api.benchmark homepage
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  retrieve main menu                  	          5	          5	              0
  retrieve product list               	          4	          4	              0
  retrieve secondary menu             	          5	          5	              0
  retrieve shop                       	          2	          2	              0

# api.benchmark product
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  product details                     	         13	         13	              3

# api.benchmark variant
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  retrieve variant list               	          9	          9	              2

@codecov
Copy link

codecov bot commented Jul 5, 2019

Codecov Report

Merging #4404 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4404      +/-   ##
=========================================
+ Coverage    90.7%   90.7%   +<.01%     
=========================================
  Files         291     291              
  Lines       16679   16680       +1     
  Branches     1691    1691              
=========================================
+ Hits        15129   15130       +1     
  Misses       1054    1054              
  Partials      496     496
Impacted Files Coverage Δ
saleor/account/validators.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04fc905...fd1af81. Read the comment docs.

@korycins korycins merged commit 25d815a into saleor:master Jul 5, 2019
@NyanKiyoshi NyanKiyoshi deleted the accounts/phones/validations branch July 5, 2019 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some invalid phone numbers throw an exception and result in server error
3 participants