Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimal quantity of products for voucher #4427

Merged
merged 18 commits into from
Jul 10, 2019

Conversation

fowczarek
Copy link
Member

@fowczarek fowczarek commented Jul 9, 2019

I want to merge this change because resolve #4316 and fix #4379

Screenshots

Pull Request Checklist

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. Database migration files are up to date.
  6. The changes are tested.
  7. The code is documented (docstrings, project documentation).
  8. GraphQL schema and type definitions are up to date.
  9. Changes are mentioned in the changelog.

@fowczarek fowczarek self-assigned this Jul 9, 2019
@fowczarek fowczarek force-pushed the 4316/voucher_min_qunantity_of_products branch from 0e7184a to 8cc8277 Compare July 9, 2019 10:05
Copy link

django-queries commented Jul 9, 2019

Here is the report for f6a298b (mirumee/saleor @ 4316/voucher_min_qunantity_of_products)
Base comparison is d528263.

No differences were found. (click me)

# api.benchmark checkout
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  add billing address to checkout     	         34	         34	             20
  add shipping to checkout            	          7	          7	              0
  checkout payment charge             	         14	         14	              0
  complete checkout                   	          6	          6	              0
  create checkout                     	         43	         43	             21

# api.benchmark homepage
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  retrieve main menu                  	          5	          5	              0
  retrieve product list               	          4	          4	              0
  retrieve secondary menu             	          5	          5	              0
  retrieve shop                       	          2	          2	              0

# api.benchmark product
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  product details                     	         13	         13	              3

# api.benchmark variant
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  retrieve variant list               	          9	          9	              2

@fowczarek fowczarek requested review from korycins, NyanKiyoshi and maarcingebala and removed request for korycins July 9, 2019 10:30
@codecov
Copy link

codecov bot commented Jul 9, 2019

Codecov Report

Merging #4427 into master will increase coverage by 0.04%.
The diff coverage is 97.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4427      +/-   ##
==========================================
+ Coverage    90.7%   90.75%   +0.04%     
==========================================
  Files         291      291              
  Lines       16680    16694      +14     
  Branches     1691     1692       +1     
==========================================
+ Hits        15130    15150      +20     
+ Misses       1054     1049       -5     
+ Partials      496      495       -1
Impacted Files Coverage Δ
saleor/graphql/discount/types.py 89.28% <ø> (ø) ⬆️
saleor/discount/utils.py 96.25% <100%> (+0.19%) ⬆️
saleor/graphql/discount/mutations.py 98.2% <100%> (+0.01%) ⬆️
saleor/dashboard/discount/forms.py 98.05% <100%> (ø) ⬆️
saleor/discount/models.py 84.37% <100%> (+0.9%) ⬆️
saleor/checkout/utils.py 83.72% <100%> (+0.59%) ⬆️
saleor/dashboard/order/utils.py 77.11% <50%> (+0.84%) ⬆️
saleor/payment/utils.py 92.01% <0%> (+0.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d528263...f6a298b. Read the comment docs.

@fowczarek fowczarek force-pushed the 4316/voucher_min_qunantity_of_products branch from 17386f0 to 6f52952 Compare July 10, 2019 08:54
saleor/checkout/utils.py Outdated Show resolved Hide resolved
saleor/checkout/utils.py Outdated Show resolved Hide resolved
@maarcingebala maarcingebala merged commit 28d1df1 into master Jul 10, 2019
@maarcingebala maarcingebala deleted the 4316/voucher_min_qunantity_of_products branch July 10, 2019 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants