-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix voucher limit value when checkbox unchecked #4456
Conversation
If you want to clear |
Now if a user clear input field (eg. |
saleor/static/dashboard-next/discounts/views/VoucherDetails.tsx
Outdated
Show resolved
Hide resolved
saleor/static/dashboard-next/discounts/views/VoucherDetails.tsx
Outdated
Show resolved
Hide resolved
Here is the report for bb91d50 (mirumee/saleor @ fix-voucher-usage-limit-check) No differences were found. (click me)
# api.benchmark checkout
test name left count right count duplicate count
------------------------------------ ----------- ----------- ---------------
add billing address to checkout 34 34 20
add shipping to checkout 7 7 0
checkout payment charge 14 14 0
complete checkout 6 6 0
create checkout 43 43 21
# api.benchmark homepage
test name left count right count duplicate count
------------------------------------ ----------- ----------- ---------------
retrieve main menu 5 5 0
retrieve product list 4 4 0
retrieve secondary menu 5 5 0
retrieve shop 2 2 0
# api.benchmark product
test name left count right count duplicate count
------------------------------------ ----------- ----------- ---------------
product details 13 13 3
# api.benchmark variant
test name left count right count duplicate count
------------------------------------ ----------- ----------- ---------------
retrieve variant list 9 9 2 |
Codecov Report
@@ Coverage Diff @@
## master #4456 +/- ##
=========================================
Coverage ? 90.72%
=========================================
Files ? 291
Lines ? 16785
Branches ? 1711
=========================================
Hits ? 15229
Misses ? 1056
Partials ? 500 Continue to review full report at Codecov.
|
saleor/static/dashboard-next/discounts/views/VoucherDetails.tsx
Outdated
Show resolved
Hide resolved
Requested changes were applied.
I want to merge this change because...
Screenshots
Pull Request Checklist