Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mutation for changing logged user first and last name #4489

Merged
merged 5 commits into from
Jul 18, 2019

Conversation

fowczarek
Copy link
Member

I want to merge this change because resolve #4289

Screenshots

Pull Request Checklist

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. Database migration files are up to date.
  6. The changes are tested.
  7. The code is documented (docstrings, project documentation).
  8. GraphQL schema and type definitions are up to date.
  9. Changes are mentioned in the changelog.

@fowczarek fowczarek self-assigned this Jul 18, 2019
Copy link

django-queries commented Jul 18, 2019

Here is the report for 03d12dc (mirumee/saleor @ 4289/Change-logged-user-email-and-names)
Base comparison is c218fb0.

No differences were found. (click me)

# api.benchmark checkout
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  add billing address to checkout     	         34	         34	             20
  add shipping to checkout            	          7	          7	              0
  checkout payment charge             	         14	         14	              0
  complete checkout                   	          6	          6	              0
  create checkout                     	         43	         43	             21

# api.benchmark homepage
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  retrieve main menu                  	          5	          5	              0
  retrieve product list               	          4	          4	              0
  retrieve secondary menu             	          5	          5	              0
  retrieve shop                       	          2	          2	              0

# api.benchmark product
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  product details                     	         13	         13	              3

# api.benchmark variant
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  retrieve variant list               	          9	          9	              2

@fowczarek fowczarek force-pushed the 4289/Change-logged-user-email-and-names branch from 139f318 to 5551a6f Compare July 18, 2019 08:13
@codecov
Copy link

codecov bot commented Jul 18, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@7a21736). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4489   +/-   ##
=========================================
  Coverage          ?   90.72%           
=========================================
  Files             ?      291           
  Lines             ?    16804           
  Branches          ?     1711           
=========================================
  Hits              ?    15246           
  Misses            ?     1057           
  Partials          ?      501
Impacted Files Coverage Δ
saleor/graphql/account/mutations.py 97.45% <100%> (ø)
saleor/graphql/account/schema.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a21736...5551a6f. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 18, 2019

Codecov Report

Merging #4489 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4489      +/-   ##
==========================================
+ Coverage   90.63%   90.64%   +0.01%     
==========================================
  Files         294      294              
  Lines       16942    16961      +19     
  Branches     1720     1720              
==========================================
+ Hits        15355    15374      +19     
  Misses       1082     1082              
  Partials      505      505
Impacted Files Coverage Δ
saleor/graphql/account/mutations.py 97.45% <100%> (+0.11%) ⬆️
saleor/graphql/account/schema.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c218fb0...03d12dc. Read the comment docs.

@fowczarek fowczarek force-pushed the 4289/Change-logged-user-email-and-names branch from 5551a6f to 15a7f42 Compare July 18, 2019 08:13
saleor/graphql/account/mutations.py Outdated Show resolved Hide resolved
saleor/graphql/account/mutations.py Outdated Show resolved Hide resolved
@fowczarek fowczarek force-pushed the 4289/Change-logged-user-email-and-names branch from f624aec to 03d12dc Compare July 18, 2019 09:04
@maarcingebala maarcingebala merged commit abfcf33 into master Jul 18, 2019
@maarcingebala maarcingebala deleted the 4289/Change-logged-user-email-and-names branch July 18, 2019 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add query for changing user email, firstName, lastName
3 participants