-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dashboard menu styles #4491
Conversation
saleor/static/dashboard-next/components/AppLayout/AppLayout.tsx
Outdated
Show resolved
Hide resolved
saleor/static/dashboard-next/components/AppLayout/AppLayout.tsx
Outdated
Show resolved
Hide resolved
saleor/static/dashboard-next/components/AppLayout/AppLayout.tsx
Outdated
Show resolved
Hide resolved
@benekex2 CI is still failing here |
Codecov Report
@@ Coverage Diff @@
## master #4491 +/- ##
==========================================
- Coverage 90.66% 90.64% -0.02%
==========================================
Files 294 294
Lines 16971 16971
Branches 1720 1720
==========================================
- Hits 15386 15384 -2
- Misses 1081 1082 +1
- Partials 504 505 +1
Continue to review full report at Codecov.
|
Here is the report for 22e39f9 (mirumee/saleor @ fix/dashboard-menu-styles) No differences were found. (click me)
# api.benchmark checkout
test name left count right count duplicate count
------------------------------------ ----------- ----------- ---------------
add billing address to checkout 34 34 20
add shipping to checkout 7 7 0
checkout payment charge 14 14 0
complete checkout 6 6 0
create checkout 43 43 21
# api.benchmark homepage
test name left count right count duplicate count
------------------------------------ ----------- ----------- ---------------
retrieve main menu 5 5 0
retrieve product list 4 4 0
retrieve secondary menu 5 5 0
retrieve shop 2 2 0
# api.benchmark product
test name left count right count duplicate count
------------------------------------ ----------- ----------- ---------------
product details 13 13 3
# api.benchmark variant
test name left count right count duplicate count
------------------------------------ ----------- ----------- ---------------
retrieve variant list 9 9 2 |
I want to merge this change because...
Screenshots
Pull Request Checklist