-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mutation for deleting account #4494
Add mutation for deleting account #4494
Conversation
Here is the report for d849171 (mirumee/saleor @ 4289/Change-logged-user-email-and-names) No differences were found. (click me)
# api.benchmark checkout
test name left count right count duplicate count
------------------------------------ ----------- ----------- ---------------
add billing address to checkout 34 34 20
add shipping to checkout 7 7 0
checkout payment charge 14 14 0
complete checkout 6 6 0
create checkout 43 43 21
# api.benchmark homepage
test name left count right count duplicate count
------------------------------------ ----------- ----------- ---------------
retrieve main menu 5 5 0
retrieve product list 4 4 0
retrieve secondary menu 5 5 0
retrieve shop 2 2 0
# api.benchmark product
test name left count right count duplicate count
------------------------------------ ----------- ----------- ---------------
product details 13 13 3
# api.benchmark variant
test name left count right count duplicate count
------------------------------------ ----------- ----------- ---------------
retrieve variant list 9 9 2 |
Codecov Report
@@ Coverage Diff @@
## master #4494 +/- ##
==========================================
+ Coverage 90.65% 90.66% +<.01%
==========================================
Files 294 294
Lines 16961 16971 +10
Branches 1720 1720
==========================================
+ Hits 15376 15386 +10
Misses 1081 1081
Partials 504 504
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I want to merge this change because resolve #4286
Screenshots
Pull Request Checklist