Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mutation for deleting account #4494

Merged
merged 4 commits into from
Jul 19, 2019

Conversation

fowczarek
Copy link
Member

@fowczarek fowczarek commented Jul 18, 2019

I want to merge this change because resolve #4286

Screenshots

Pull Request Checklist

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. Database migration files are up to date.
  6. The changes are tested.
  7. The code is documented (docstrings, project documentation).
  8. GraphQL schema and type definitions are up to date.
  9. Changes are mentioned in the changelog.

@fowczarek fowczarek self-assigned this Jul 18, 2019
Copy link

django-queries commented Jul 18, 2019

Here is the report for d849171 (mirumee/saleor @ 4289/Change-logged-user-email-and-names)
Base comparison is abfcf33.

No differences were found. (click me)

# api.benchmark checkout
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  add billing address to checkout     	         34	         34	             20
  add shipping to checkout            	          7	          7	              0
  checkout payment charge             	         14	         14	              0
  complete checkout                   	          6	          6	              0
  create checkout                     	         43	         43	             21

# api.benchmark homepage
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  retrieve main menu                  	          5	          5	              0
  retrieve product list               	          4	          4	              0
  retrieve secondary menu             	          5	          5	              0
  retrieve shop                       	          2	          2	              0

# api.benchmark product
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  product details                     	         13	         13	              3

# api.benchmark variant
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  retrieve variant list               	          9	          9	              2

@codecov
Copy link

codecov bot commented Jul 18, 2019

Codecov Report

Merging #4494 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4494      +/-   ##
==========================================
+ Coverage   90.65%   90.66%   +<.01%     
==========================================
  Files         294      294              
  Lines       16961    16971      +10     
  Branches     1720     1720              
==========================================
+ Hits        15376    15386      +10     
  Misses       1081     1081              
  Partials      504      504
Impacted Files Coverage Δ
saleor/graphql/account/mutations.py 97.51% <100%> (+0.05%) ⬆️
saleor/graphql/account/schema.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abfcf33...d849171. Read the comment docs.

@fowczarek fowczarek marked this pull request as ready for review July 18, 2019 12:37
saleor/graphql/account/mutations.py Outdated Show resolved Hide resolved
saleor/graphql/account/mutations.py Outdated Show resolved Hide resolved
tests/api/test_account.py Outdated Show resolved Hide resolved
tests/api/test_account.py Outdated Show resolved Hide resolved
Copy link
Member

@NyanKiyoshi NyanKiyoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maarcingebala maarcingebala merged commit 40e7cb2 into master Jul 19, 2019
@maarcingebala maarcingebala deleted the 4289/Change-logged-user-email-and-names branch July 19, 2019 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add mutation for removing user account
4 participants