-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable extension manager for taxes #4497
Enable extension manager for taxes #4497
Conversation
@salwator @maarcingebala @NyanKiyoshi All logic from |
Here is the report for e875d72 (korycins/saleor @ enable_extension_manager_for_taxes) No differences were found. (click me)
# api.benchmark checkout
test name left count right count duplicate count
------------------------------------ ----------- ----------- ---------------
add billing address to checkout 34 34 20
add shipping to checkout 7 7 0
checkout payment charge 14 14 0
complete checkout 6 6 0
create checkout 41 41 20
# api.benchmark homepage
test name left count right count duplicate count
------------------------------------ ----------- ----------- ---------------
retrieve main menu 5 5 0
retrieve product list 4 4 0
retrieve secondary menu 5 5 0
retrieve shop 2 2 0
# api.benchmark product
test name left count right count duplicate count
------------------------------------ ----------- ----------- ---------------
product details 13 13 3
# api.benchmark variant
test name left count right count duplicate count
------------------------------------ ----------- ----------- ---------------
retrieve variant list 9 9 2 |
Codecov Report
@@ Coverage Diff @@
## master #4497 +/- ##
==========================================
+ Coverage 90.62% 90.82% +0.19%
==========================================
Files 297 297
Lines 17434 17469 +35
Branches 1746 1745 -1
==========================================
+ Hits 15800 15866 +66
+ Misses 1122 1092 -30
+ Partials 512 511 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great but seems there are no documentation changes?
@maarcingebala @patrys Documentation has been added. |
calling some actions when an order has been created. | ||
|
||
|
||
ExtensionsManager |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should start with "how to use it" before we dive into the details of implementing a custom plugin and eventually a custom manager (not sure if we should event document that part).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think https://docs.djangoproject.com/en/2.2/topics/http/middleware/ is a good reference for what type of information we would need to provide (but I would still document installing plugins before writing custom ones).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@patrys I've changed the structure as you said. Can you take a look one more time?
Convert all taxes logic into a plugin architecture
vatlayer
into Pluginavatax
into PluginIt closes #3992