Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order is no longer created when the payment was unsuccessful in the API #4500

Merged
merged 1 commit into from
Jul 22, 2019

Conversation

NyanKiyoshi
Copy link
Member

Pull Request Checklist

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. Database migration files are up to date.
  6. The changes are tested.
  7. The code is documented (docstrings, project documentation).
  8. GraphQL schema and type definitions are up to date.
  9. Changes are mentioned in the changelog.

@NyanKiyoshi NyanKiyoshi added bug graphql Issues related to the GraphQL API labels Jul 19, 2019
@NyanKiyoshi NyanKiyoshi self-assigned this Jul 19, 2019
Copy link

django-queries commented Jul 19, 2019

Here is the report for 2981de6 (NyanKiyoshi/saleor @ api/checkout/payment)
Base comparison is 51b587f.

No differences were found. (click me)

# api.benchmark checkout
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  add billing address to checkout     	         34	         34	             20
  add shipping to checkout            	          7	          7	              0
  checkout payment charge             	         14	         14	              0
  complete checkout                   	          6	          6	              0
  create checkout                     	         41	         41	             20

# api.benchmark homepage
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  retrieve main menu                  	          5	          5	              0
  retrieve product list               	          4	          4	              0
  retrieve secondary menu             	          5	          5	              0
  retrieve shop                       	          2	          2	              0

# api.benchmark product
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  product details                     	         13	         13	              3

# api.benchmark variant
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  retrieve variant list               	          9	          9	              2

@codecov
Copy link

codecov bot commented Jul 19, 2019

Codecov Report

Merging #4500 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4500   +/-   ##
=======================================
  Coverage   90.58%   90.58%           
=======================================
  Files         295      295           
  Lines       17030    17030           
  Branches     1734     1734           
=======================================
  Hits        15426    15426           
  Misses       1098     1098           
  Partials      506      506

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51b587f...2981de6. Read the comment docs.

@maarcingebala maarcingebala merged commit e43d26c into saleor:master Jul 22, 2019
@NyanKiyoshi NyanKiyoshi deleted the api/checkout/payment branch July 22, 2019 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug graphql Issues related to the GraphQL API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants