Fix generating random avatars when updating staff accounts #4521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is the report for 6171e5b (maarcingebala/saleor @ fix-updating-the-customer) No differences were found. (click me)
# api.benchmark checkout
test name left count right count duplicate count
------------------------------------ ----------- ----------- ---------------
add billing address to checkout 34 34 20
add shipping to checkout 7 7 0
checkout payment charge 14 14 0
complete checkout 6 6 0
create checkout 41 41 20
# api.benchmark homepage
test name left count right count duplicate count
------------------------------------ ----------- ----------- ---------------
retrieve main menu 5 5 0
retrieve product list 4 4 0
retrieve secondary menu 5 5 0
retrieve shop 2 2 0
# api.benchmark product
test name left count right count duplicate count
------------------------------------ ----------- ----------- ---------------
product details 13 13 3
# api.benchmark variant
test name left count right count duplicate count
------------------------------------ ----------- ----------- ---------------
retrieve variant list 9 9 2 |
Codecov Report
@@ Coverage Diff @@
## master #4521 +/- ##
==========================================
- Coverage 90.63% 90.62% -0.01%
==========================================
Files 297 297
Lines 17434 17437 +3
Branches 1746 1748 +2
==========================================
+ Hits 15802 15803 +1
- Misses 1121 1122 +1
- Partials 511 512 +1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #4521 +/- ##
==========================================
+ Coverage 90.62% 90.62% +<.01%
==========================================
Files 297 297
Lines 17434 17437 +3
Branches 1746 1748 +2
==========================================
+ Hits 15800 15803 +3
Misses 1122 1122
Partials 512 512
Continue to review full report at Codecov.
|
NyanKiyoshi
approved these changes
Jul 24, 2019
| @@ -1131,6 +1132,47 @@ def test_staff_update(staff_api_client, permission_manage_staff, media_root): | |||
| assert not data["user"]["isActive"] | |||
|
|
|||
|
|
|||
| @patch("saleor.graphql.account.mutations.get_random_avatar") | |||
There was a problem hiding this comment.
We could patch create_user_avatar_thumbnails and assert mocked_thumbnail_creator.call_count == 0
korycins
reviewed
Jul 25, 2019
korycins
approved these changes
Jul 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
staffUpdatemutation would generate a new avatar image, even if one was already set. This PR changes this behavior to generate a new avatar if it's empty.Pull Request Checklist