Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input UI changes #4542

Merged
merged 14 commits into from
Jul 29, 2019
Merged

Input UI changes #4542

merged 14 commits into from
Jul 29, 2019

Conversation

benekex2
Copy link
Contributor

@benekex2 benekex2 commented Jul 26, 2019

Resolves #4421

Screenshots

Pull Request Checklist

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. Database migration files are up to date.
  6. The changes are tested.
  7. The code is documented (docstrings, project documentation).
  8. GraphQL schema and type definitions are up to date.
  9. Changes are mentioned in the changelog.

@codecov
Copy link

codecov bot commented Jul 26, 2019

Codecov Report

Merging #4542 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4542      +/-   ##
==========================================
- Coverage   90.64%   90.62%   -0.02%     
==========================================
  Files         297      297              
  Lines       17437    17437              
  Branches     1748     1748              
==========================================
- Hits        15805    15803       -2     
- Misses       1121     1122       +1     
- Partials      511      512       +1
Impacted Files Coverage Δ
saleor/payment/utils.py 90.47% <0%> (-0.87%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf43e0e...6c97f99. Read the comment docs.

Copy link

Here is the report for 6c97f99 (mirumee/saleor @ fix/input-styles)
Base comparison is cf43e0e.

No differences were found. (click me)

# api.benchmark checkout
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  add billing address to checkout     	         34	         34	             20
  add shipping to checkout            	          7	          7	              0
  checkout payment charge             	         14	         14	              0
  complete checkout                   	          6	          6	              0
  create checkout                     	         41	         41	             20

# api.benchmark homepage
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  retrieve main menu                  	          5	          5	              0
  retrieve product list               	          4	          4	              0
  retrieve secondary menu             	          5	          5	              0
  retrieve shop                       	          2	          2	              0

# api.benchmark product
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  product details                     	         13	         13	              3

# api.benchmark variant
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  retrieve variant list               	          9	          9	              2

@maarcingebala maarcingebala merged commit 0a7abc7 into master Jul 29, 2019
@maarcingebala maarcingebala deleted the fix/input-styles branch July 29, 2019 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Input UI changes
4 participants