-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display menu item form errors #4551
Conversation
Here is the report for bd2b27e (mirumee/saleor @ fix/display-menu-errors) No differences were found. (click me)
# api.benchmark checkout
test name left count right count duplicate count
------------------------------------ ----------- ----------- ---------------
add billing address to checkout 34 34 20
add shipping to checkout 7 7 0
checkout payment charge 14 14 0
complete checkout 6 6 0
create checkout 41 41 20
# api.benchmark homepage
test name left count right count duplicate count
------------------------------------ ----------- ----------- ---------------
retrieve main menu 5 5 0
retrieve product list 4 4 0
retrieve secondary menu 5 5 0
retrieve shop 2 2 0
# api.benchmark product
test name left count right count duplicate count
------------------------------------ ----------- ----------- ---------------
product details 13 13 3
# api.benchmark variant
test name left count right count duplicate count
------------------------------------ ----------- ----------- ---------------
retrieve variant list 9 9 2 |
Codecov Report
@@ Coverage Diff @@
## master #4551 +/- ##
=========================================
- Coverage 90.83% 90.64% -0.2%
=========================================
Files 297 297
Lines 17447 17437 -10
Branches 1735 1748 +13
=========================================
- Hits 15848 15805 -43
- Misses 1092 1121 +29
- Partials 507 511 +4
Continue to review full report at Codecov.
|
): [T, Dispatch<SetStateAction<T>>] { | ||
const [state, setState] = useState(data); | ||
const [prevData, setPrevData] = useState(data); | ||
|
||
const { mergeFunc, onRefresh } = opts; | ||
if (!opts) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unnecessary braces
|
||
if (open !== prevOpenState) { | ||
setPrevOpenstate(open); | ||
if (!open) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unnecessary braces
I want to merge this change because it fixes error displaying and empty value handling in menu item dialog.
Fixes #4547
Screenshots
Pull Request Checklist