Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display menu item form errors #4551

Merged
merged 10 commits into from
Jul 30, 2019
Merged

Display menu item form errors #4551

merged 10 commits into from
Jul 30, 2019

Conversation

dominik-zeglen
Copy link
Contributor

I want to merge this change because it fixes error displaying and empty value handling in menu item dialog.
Fixes #4547

Screenshots

Screenshot 2019-07-29 at 13 14 33

Screenshot 2019-07-29 at 13 29 02

Pull Request Checklist

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. Database migration files are up to date.
  6. The changes are tested.
  7. The code is documented (docstrings, project documentation).
  8. GraphQL schema and type definitions are up to date.
  9. Changes are mentioned in the changelog.

Copy link

Here is the report for bd2b27e (mirumee/saleor @ fix/display-menu-errors)
Base comparison is cf43e0e.

No differences were found. (click me)

# api.benchmark checkout
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  add billing address to checkout     	         34	         34	             20
  add shipping to checkout            	          7	          7	              0
  checkout payment charge             	         14	         14	              0
  complete checkout                   	          6	          6	              0
  create checkout                     	         41	         41	             20

# api.benchmark homepage
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  retrieve main menu                  	          5	          5	              0
  retrieve product list               	          4	          4	              0
  retrieve secondary menu             	          5	          5	              0
  retrieve shop                       	          2	          2	              0

# api.benchmark product
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  product details                     	         13	         13	              3

# api.benchmark variant
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  retrieve variant list               	          9	          9	              2

@codecov
Copy link

codecov bot commented Jul 29, 2019

Codecov Report

Merging #4551 into master will decrease coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #4551     +/-   ##
=========================================
- Coverage   90.83%   90.64%   -0.2%     
=========================================
  Files         297      297             
  Lines       17447    17437     -10     
  Branches     1735     1748     +13     
=========================================
- Hits        15848    15805     -43     
- Misses       1092     1121     +29     
- Partials      507      511      +4
Impacted Files Coverage Δ
saleor/core/extensions/manager.py 77.08% <0%> (-12.5%) ⬇️
saleor/dashboard/menu/utils.py 90.76% <0%> (-9.24%) ⬇️
saleor/core/templatetags/taxed_prices.py 80.95% <0%> (-7.94%) ⬇️
saleor/checkout/utils.py 83.64% <0%> (-0.39%) ⬇️
saleor/graphql/menu/mutations.py 97.26% <0%> (-0.32%) ⬇️
saleor/checkout/views/__init__.py 85.82% <0%> (-0.32%) ⬇️
saleor/product/utils/availability.py 97.18% <0%> (-0.16%) ⬇️
saleor/core/middleware.py 76.05% <0%> (-0.14%) ⬇️
saleor/checkout/forms.py 94.38% <0%> (-0.1%) ⬇️
saleor/dashboard/order/forms.py 87.36% <0%> (-0.07%) ⬇️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 216fbbd...60a5009. Read the comment docs.

): [T, Dispatch<SetStateAction<T>>] {
const [state, setState] = useState(data);
const [prevData, setPrevData] = useState(data);

const { mergeFunc, onRefresh } = opts;
if (!opts) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary braces


if (open !== prevOpenState) {
setPrevOpenstate(open);
if (!open) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary braces

@maarcingebala maarcingebala merged commit 4a75513 into master Jul 30, 2019
@maarcingebala maarcingebala deleted the fix/display-menu-errors branch July 30, 2019 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigation item without a link breaks the dashboard
4 participants