Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add voucher settings #4556

Merged
merged 9 commits into from
Jul 30, 2019
Merged

Add voucher settings #4556

merged 9 commits into from
Jul 30, 2019

Conversation

benekex2
Copy link
Contributor

@benekex2 benekex2 commented Jul 29, 2019

Ref #4434

Screenshots

Pull Request Checklist

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. Database migration files are up to date.
  6. The changes are tested.
  7. The code is documented (docstrings, project documentation).
  8. GraphQL schema and type definitions are up to date.
  9. Changes are mentioned in the changelog.

Copy link

django-queries commented Jul 29, 2019

Here is the report for c25bbae (mirumee/saleor @ add-voucher-settings)
Base comparison is 94314bf.

No differences were found. (click me)

# api.benchmark checkout
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  add billing address to checkout     	         34	         34	             20
  add shipping to checkout            	          7	          7	              0
  checkout payment charge             	         14	         14	              0
  complete checkout                   	          6	          6	              0
  create checkout                     	         41	         41	             20

# api.benchmark homepage
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  retrieve main menu                  	          5	          5	              0
  retrieve product list               	          4	          4	              0
  retrieve secondary menu             	          5	          5	              0
  retrieve shop                       	          2	          2	              0

# api.benchmark product
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  product details                     	         13	         13	              3

# api.benchmark variant
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  retrieve variant list               	          9	          9	              2

@codecov
Copy link

codecov bot commented Jul 29, 2019

Codecov Report

Merging #4556 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4556      +/-   ##
==========================================
+ Coverage   90.64%   90.66%   +0.01%     
==========================================
  Files         297      297              
  Lines       17411    17411              
  Branches     1738     1738              
==========================================
+ Hits        15783    15785       +2     
+ Misses       1121     1120       -1     
+ Partials      507      506       -1
Impacted Files Coverage Δ
saleor/payment/utils.py 91.34% <0%> (+0.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7feb6d9...9fd99d0. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 29, 2019

Codecov Report

Merging #4556 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4556   +/-   ##
=======================================
  Coverage   90.88%   90.88%           
=======================================
  Files         296      296           
  Lines       17435    17435           
  Branches     1734     1734           
=======================================
  Hits        15845    15845           
  Misses       1083     1083           
  Partials      507      507

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94314bf...c25bbae. Read the comment docs.

requirementsPickerInitValue = "ITEM";
} else {
requirementsPickerInitValue = "NONE";
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's extract this to function

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? This is used only once.

formData.requirementsPicker === "NONE" ||
formData.requirementsPicker === "ORDER"
? 0
: parseFloat(formData.minCheckoutItemsQuantity),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maarcingebala maarcingebala merged commit ea758d5 into master Jul 30, 2019
@maarcingebala maarcingebala deleted the add-voucher-settings branch July 30, 2019 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants