-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add voucher settings #4556
Add voucher settings #4556
Conversation
bf48486
to
6b522bc
Compare
Here is the report for c25bbae (mirumee/saleor @ add-voucher-settings) No differences were found. (click me)
# api.benchmark checkout
test name left count right count duplicate count
------------------------------------ ----------- ----------- ---------------
add billing address to checkout 34 34 20
add shipping to checkout 7 7 0
checkout payment charge 14 14 0
complete checkout 6 6 0
create checkout 41 41 20
# api.benchmark homepage
test name left count right count duplicate count
------------------------------------ ----------- ----------- ---------------
retrieve main menu 5 5 0
retrieve product list 4 4 0
retrieve secondary menu 5 5 0
retrieve shop 2 2 0
# api.benchmark product
test name left count right count duplicate count
------------------------------------ ----------- ----------- ---------------
product details 13 13 3
# api.benchmark variant
test name left count right count duplicate count
------------------------------------ ----------- ----------- ---------------
retrieve variant list 9 9 2 |
Codecov Report
@@ Coverage Diff @@
## master #4556 +/- ##
==========================================
+ Coverage 90.64% 90.66% +0.01%
==========================================
Files 297 297
Lines 17411 17411
Branches 1738 1738
==========================================
+ Hits 15783 15785 +2
+ Misses 1121 1120 -1
+ Partials 507 506 -1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #4556 +/- ##
=======================================
Coverage 90.88% 90.88%
=======================================
Files 296 296
Lines 17435 17435
Branches 1734 1734
=======================================
Hits 15845 15845
Misses 1083 1083
Partials 507 507 Continue to review full report at Codecov.
|
requirementsPickerInitValue = "ITEM"; | ||
} else { | ||
requirementsPickerInitValue = "NONE"; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's extract this to function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why? This is used only once.
saleor/static/dashboard-next/discounts/components/VoucherDetailsPage/VoucherDetailsPage.tsx
Outdated
Show resolved
Hide resolved
saleor/static/dashboard-next/discounts/components/VoucherRequirements/VoucherRequirements.tsx
Outdated
Show resolved
Hide resolved
saleor/static/dashboard-next/discounts/components/VoucherRequirements/VoucherRequirements.tsx
Outdated
Show resolved
Hide resolved
formData.requirementsPicker === "NONE" || | ||
formData.requirementsPicker === "ORDER" | ||
? 0 | ||
: parseFloat(formData.minCheckoutItemsQuantity), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the same as
https://github.com/mirumee/saleor/pull/4556/files/9fd99d048ad050ea247a01fef15305aeea6375bb#diff-95dd24f9158deb91b0d37a41f830804cR339
so it can be extracted to helper function at the section level
Ref #4434
Screenshots
Pull Request Checklist