-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No longer accept invalid IP addresses in core's get_client_ip #4597
No longer accept invalid IP addresses in core's get_client_ip #4597
Conversation
83efa14
to
2cc4ab2
Compare
Here is the report for a8ab73b (NyanKiyoshi/saleor @ core/ip/check-if-valid) No differences were found. (click me)
# api.benchmark checkout
test name left count right count duplicate count
------------------------------------ ----------- ----------- ---------------
add billing address to checkout 34 34 20
add shipping to checkout 7 7 0
checkout payment charge 14 14 0
complete checkout 6 6 0
create checkout 48 48 24
# api.benchmark homepage
test name left count right count duplicate count
------------------------------------ ----------- ----------- ---------------
retrieve main menu 5 5 0
retrieve product list 4 4 0
retrieve secondary menu 5 5 0
retrieve shop 2 2 0
# api.benchmark product
test name left count right count duplicate count
------------------------------------ ----------- ----------- ---------------
product details 13 13 3
# api.benchmark variant
test name left count right count duplicate count
------------------------------------ ----------- ----------- ---------------
retrieve variant list 9 9 2 |
Codecov Report
@@ Coverage Diff @@
## master #4597 +/- ##
=========================================
+ Coverage 90.89% 90.9% +<.01%
=========================================
Files 296 296
Lines 17462 17477 +15
Branches 1738 1739 +1
=========================================
+ Hits 15872 15887 +15
Misses 1086 1086
Partials 504 504
Continue to review full report at Codecov.
|
2cc4ab2
to
dbb54df
Compare
dbb54df
to
a8ab73b
Compare
Closes #4595.
This fixes the error
ValueError: 'Oopsie?' does not appear to be an IPv4 or IPv6 address
when trying to get the user's country.Screenshots
Pull Request Checklist