-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to toggle visible columns in product list #4608
Conversation
Here is the report for 8cbc141 (mirumee/saleor @ attributes/add-column-settings) No differences were found. (click me)
# api.benchmark checkout
test name left count right count duplicate count
------------------------------------ ----------- ----------- ---------------
add billing address to checkout 34 34 20
add shipping to checkout 7 7 0
checkout payment charge 14 14 0
complete checkout 6 6 0
create checkout 48 48 24
# api.benchmark homepage
test name left count right count duplicate count
------------------------------------ ----------- ----------- ---------------
retrieve main menu 5 5 0
retrieve product list 4 4 0
retrieve secondary menu 5 5 0
retrieve shop 2 2 0
# api.benchmark product
test name left count right count duplicate count
------------------------------------ ----------- ----------- ---------------
product details 13 13 3
# api.benchmark variant
test name left count right count duplicate count
------------------------------------ ----------- ----------- ---------------
retrieve variant list 15 15 8 |
Codecov Report
@@ Coverage Diff @@
## master #4608 +/- ##
=======================================
Coverage 91.24% 91.24%
=======================================
Files 301 301
Lines 17970 17970
Branches 1788 1788
=======================================
Hits 16397 16397
Misses 1072 1072
Partials 501 501 Continue to review full report at Codecov.
|
405fc13
to
b86d33f
Compare
44bae3e
to
68bc807
Compare
f663d01
to
4e3589e
Compare
68bc807
to
5a1bd22
Compare
@dominik-zeglen I'm getting this error when trying to view the product list:
|
Investigating |
saleor/static/dashboard-next/collections/components/CollectionProducts/CollectionProducts.tsx
Outdated
Show resolved
Hide resolved
saleor/static/dashboard-next/components/AssignProductDialog/AssignProductDialog.tsx
Outdated
Show resolved
Hide resolved
saleor/static/dashboard-next/components/ColumnPicker/ColumnPicker.tsx
Outdated
Show resolved
Hide resolved
saleor/static/dashboard-next/components/ProductList/ProductList.tsx
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #4608 +/- ##
==========================================
+ Coverage 91.36% 91.37% +0.01%
==========================================
Files 307 307
Lines 18198 18198
Branches 1813 1813
==========================================
+ Hits 16626 16628 +2
+ Misses 1057 1056 -1
+ Partials 515 514 -1
Continue to review full report at Codecov.
|
8ce68e7
to
1dd69d2
Compare
I want to merge this change because it adds ability to toggle which columns are visible in product list 馃挴
Note: I had to refactor
<TableCellAvatar />
so this PR introduces little changes to other lists using this component.Screenshots
Pull Request Checklist