Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to toggle visible columns in product list #4608

Merged
merged 16 commits into from
Aug 8, 2019

Conversation

dominik-zeglen
Copy link
Contributor

@dominik-zeglen dominik-zeglen commented Aug 6, 2019

I want to merge this change because it adds ability to toggle which columns are visible in product list 馃挴

Note: I had to refactor <TableCellAvatar /> so this PR introduces little changes to other lists using this component.

Screenshots

Screenshot 2019-08-06 at 17 56 03

Pull Request Checklist

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. Database migration files are up to date.
  6. The changes are tested.
  7. The code is documented (docstrings, project documentation).
  8. GraphQL schema and type definitions are up to date.
  9. Changes are mentioned in the changelog.

Copy link

django-queries commented Aug 6, 2019

Here is the report for 8cbc141 (mirumee/saleor @ attributes/add-column-settings)
Base comparison is f7c8814.

No differences were found. (click me)

# api.benchmark checkout
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  add billing address to checkout     	         34	         34	             20
  add shipping to checkout            	          7	          7	              0
  checkout payment charge             	         14	         14	              0
  complete checkout                   	          6	          6	              0
  create checkout                     	         48	         48	             24

# api.benchmark homepage
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  retrieve main menu                  	          5	          5	              0
  retrieve product list               	          4	          4	              0
  retrieve secondary menu             	          5	          5	              0
  retrieve shop                       	          2	          2	              0

# api.benchmark product
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  product details                     	         13	         13	              3

# api.benchmark variant
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  retrieve variant list               	         15	         15	              8

@codecov
Copy link

codecov bot commented Aug 6, 2019

Codecov Report

Merging #4608 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4608   +/-   ##
=======================================
  Coverage   91.24%   91.24%           
=======================================
  Files         301      301           
  Lines       17970    17970           
  Branches     1788     1788           
=======================================
  Hits        16397    16397           
  Misses       1072     1072           
  Partials      501      501

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 0922898...815ba7d. Read the comment docs.

@NyanKiyoshi NyanKiyoshi force-pushed the next/enterprise-grade-attributes branch 2 times, most recently from 405fc13 to b86d33f Compare August 7, 2019 13:38
@dominik-zeglen dominik-zeglen force-pushed the attributes/add-column-settings branch 2 times, most recently from 44bae3e to 68bc807 Compare August 7, 2019 14:34
@NyanKiyoshi NyanKiyoshi force-pushed the next/enterprise-grade-attributes branch from f663d01 to 4e3589e Compare August 7, 2019 14:59
@maarcingebala maarcingebala changed the base branch from next/enterprise-grade-attributes to master August 8, 2019 11:25
@maarcingebala
Copy link
Member

@dominik-zeglen I'm getting this error when trying to view the product list:

Uncaught TypeError: Cannot read property 'length' of undefined
    at eval (webpack-internal:///./saleor/static/dashboard-next/components/ProductList/ProductList.tsx:82)
    at renderWithHooks (webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:12938)
    at mountIndeterminateComponent (webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:15020)
    at beginWork (webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:15625)
    at performUnitOfWork (webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:19312)
    at workLoop (webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:19352)
    at HTMLUnknownElement.callCallback (webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:149)
    at Object.invokeGuardedCallbackDev (webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:199)
    at invokeGuardedCallback (webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:256)
    at replayUnitOfWork (webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:18578)
webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:17117

The above error occurred in one of your React components:
    in Unknown (created by ProductList)
    in ProductList (created by ProductListPage)
    in div (created by Paper)
    in Paper (created by WithStyles(Paper))
    in WithStyles(Paper) (created by Card)
    in Card (created by WithStyles(Card))
    in WithStyles(Card) (created by ProductListPage)
    in div
    in Unknown (created by Container)
    in Container (created by ProductListPage)
    in ProductListPage (created by StrictTypedMutation)
    in StrictTypedMutation
    in Unknown (created by StrictTypedMutation)
    in StrictTypedMutation
    in Unknown (created by StrictTypedQuery)
    in QueryProgress (created by StrictTypedQuery)
    in StrictTypedQuery (created by Context.Consumer)
    in Unknown
    in Unknown (created by ProductList)
    in ProductList (created by Context.Consumer)
    in Route (created by Component)
    in Switch (created by Component)
    in Component (created by Context.Consumer)
    in Route (created by Context.Consumer)
    in main (created by Context.Consumer)
    in div (created by Context.Consumer)
    in div (created by Context.Consumer)
    in Unknown (created by Context.Consumer)
    in withRouter() (created by WithStyles(withRouter()))
    in WithStyles(withRouter()) (created by Context.Consumer)
    in Route (created by AuthProvider)
    in Switch (created by AuthProvider)
    in AuthProvider (created by StrictTypedMutation)
    in StrictTypedMutation
    in Unknown (created by StrictTypedMutation)
    in StrictTypedMutation
    in Unknown (created by AuthProviderOperations)
    in AuthProviderOperations (created by App)
    in StrictTypedQuery (created by Context.Consumer)
    in Unknown
    in Unknown (created by App)
    in Unknown (created by App)
    in MessageManager (created by App)
    in LocaleProvider (created by App)
    in DateProvider (created by App)
    in ThemeProvider (created by ThemeProvider)
    in MuiThemeProviderOld (created by ThemeProvider)
    in ThemeProvider (created by App)
    in Router (created by BrowserRouter)
    in BrowserRouter (created by App)
    in ApolloProvider (created by App)
    in App

@dominik-zeglen
Copy link
Contributor Author

Investigating

@codecov
Copy link

codecov bot commented Aug 8, 2019

Codecov Report

Merging #4608 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4608      +/-   ##
==========================================
+ Coverage   91.36%   91.37%   +0.01%     
==========================================
  Files         307      307              
  Lines       18198    18198              
  Branches     1813     1813              
==========================================
+ Hits        16626    16628       +2     
+ Misses       1057     1056       -1     
+ Partials      515      514       -1
Impacted Files Coverage 螖
saleor/payment/utils.py 91.34% <0%> (+0.86%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update f7c8814...8cbc141. Read the comment docs.

@maarcingebala maarcingebala merged commit 1b5141e into master Aug 8, 2019
@maarcingebala maarcingebala deleted the attributes/add-column-settings branch August 8, 2019 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants