Serialize empty URL as string when creating menu items #4616
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_menu_item_as_dict
function used to serialize menus to JSON (which is used by Storefront 1.0 for rendering menus) was serializing empty URLs asNone
. As a result, one could create menu items that were rendered in Storefront ashttp://localhost:8000/en/None
. This PR changes this behavior to link to the homepage in such case.Pull Request Checklist