Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor password recovery mutations #4617

Merged
merged 8 commits into from
Aug 14, 2019

Conversation

fowczarek
Copy link
Member

@fowczarek fowczarek commented Aug 8, 2019

I want to merge this change because resolve #4153

Screenshots

Pull Request Checklist

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. Database migration files are up to date.
  6. The changes are tested.
  7. GraphQL schema and type definitions are up to date.
  8. Changes are mentioned in the changelog.

@fowczarek fowczarek added in progress graphql Issues related to the GraphQL API labels Aug 8, 2019
@fowczarek fowczarek self-assigned this Aug 8, 2019
Copy link

django-queries commented Aug 8, 2019

Here is the report for 0331a93 (mirumee/saleor @ 4153/Reactor_password_recovery_mutations)
Base comparison is 1943069.

No differences were found. (click me)

# api.benchmark checkout
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  add billing address to checkout     	         34	         34	             20
  add shipping to checkout            	          7	          7	              0
  checkout payment charge             	         14	         14	              0
  complete checkout                   	          6	          6	              0
  create checkout                     	         48	         48	             24

# api.benchmark homepage
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  retrieve main menu                  	          5	          5	              0
  retrieve product list               	          4	          4	              0
  retrieve secondary menu             	          5	          5	              0
  retrieve shop                       	          2	          2	              0

# api.benchmark product
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  product details                     	         13	         13	              3

# api.benchmark variant
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  retrieve variant list               	         15	         15	              8

@codecov
Copy link

codecov bot commented Aug 9, 2019

Codecov Report

Merging #4617 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4617      +/-   ##
==========================================
- Coverage   91.25%   91.25%   -0.01%     
==========================================
  Files         301      301              
  Lines       17970    17979       +9     
  Branches     1788     1788              
==========================================
+ Hits        16399    16406       +7     
- Misses       1071     1072       +1     
- Partials      500      501       +1
Impacted Files Coverage Δ
saleor/graphql/account/mutations/base.py 98.12% <100%> (+0.11%) ⬆️
saleor/payment/utils.py 90.47% <0%> (-0.87%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e96b57d...90bddff. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 9, 2019

Codecov Report

Merging #4617 into master will increase coverage by 0.01%.
The diff coverage is 97.01%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4617      +/-   ##
==========================================
+ Coverage   91.36%   91.37%   +0.01%     
==========================================
  Files         307      308       +1     
  Lines       18197    18235      +38     
  Branches     1813     1814       +1     
==========================================
+ Hits        16625    16663      +38     
- Misses       1057     1058       +1     
+ Partials      515      514       -1
Impacted Files Coverage Δ
saleor/graphql/account/mutations/base.py 98.12% <100%> (+0.11%) ⬆️
...leor/graphql/account/mutations/deprecated_staff.py 100% <100%> (ø) ⬆️
...or/graphql/account/mutations/deprecated_account.py 100% <100%> (ø) ⬆️
saleor/account/emails.py 86.2% <100%> (+8.42%) ⬆️
saleor/core/utils/url.py 81.81% <81.81%> (ø)
saleor/payment/utils.py 91.34% <0%> (+0.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1943069...0331a93. Read the comment docs.

@fowczarek fowczarek force-pushed the 4153/Reactor_password_recovery_mutations branch from 90bddff to 494cbfb Compare August 9, 2019 11:44
@fowczarek fowczarek force-pushed the 4153/Reactor_password_recovery_mutations branch from 64ee9bc to 8b1ea65 Compare August 13, 2019 10:23
saleor/graphql/account/mutations/base.py Outdated Show resolved Hide resolved
saleor/graphql/account/mutations/base.py Outdated Show resolved Hide resolved
saleor/graphql/account/mutations/base.py Outdated Show resolved Hide resolved
saleor/account/emails.py Outdated Show resolved Hide resolved
saleor/core/utils/url.py Outdated Show resolved Hide resolved
@fowczarek fowczarek force-pushed the 4153/Reactor_password_recovery_mutations branch from a8079b8 to 0331a93 Compare August 14, 2019 06:19
@maarcingebala maarcingebala merged commit b76eaee into master Aug 14, 2019
@maarcingebala maarcingebala deleted the 4153/Reactor_password_recovery_mutations branch August 14, 2019 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
graphql Issues related to the GraphQL API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactoring of password recovery system
4 participants