-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change AddressValidationRules API #4655
Conversation
Here is the report for f33fb0a (mirumee/saleor @ change-address-validator-api) No differences were found. (click me)
# api.benchmark checkout
test name left count right count duplicate count
------------------------------------ ----------- ----------- ---------------
add billing address to checkout 34 34 20
add shipping to checkout 7 7 0
checkout payment charge 14 14 0
complete checkout 6 6 0
create checkout 48 48 24
# api.benchmark homepage
test name left count right count duplicate count
------------------------------------ ----------- ----------- ---------------
retrieve main menu 5 5 0
retrieve product list 4 4 0
retrieve secondary menu 5 5 0
retrieve shop 2 2 0
# api.benchmark product
test name left count right count duplicate count
------------------------------------ ----------- ----------- ---------------
product details 13 13 3
# api.benchmark variant
test name left count right count duplicate count
------------------------------------ ----------- ----------- ---------------
retrieve variant list 15 15 8 |
Codecov Report
@@ Coverage Diff @@
## master #4655 +/- ##
==========================================
+ Coverage 91.36% 91.37% +<.01%
==========================================
Files 308 308
Lines 18236 18244 +8
Branches 1814 1816 +2
==========================================
+ Hits 16662 16671 +9
+ Misses 1059 1058 -1
Partials 515 515
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #4655 +/- ##
==========================================
- Coverage 91.43% 91.37% -0.06%
==========================================
Files 307 308 +1
Lines 18419 18244 -175
Branches 1842 1816 -26
==========================================
- Hits 16841 16671 -170
+ Misses 1060 1058 -2
+ Partials 518 515 -3
Continue to review full report at Codecov.
|
39325a7
to
f33fb0a
Compare
I want to merge this change because it brings several minor changes to the
AddressValidationRules
endpoint.First of all, it changes query's signature to take country code of type
CountryCode!
, addscity
to the parameters, it drops support for country guessing based on GeoIP.The second thing is returning allowed and required field names in camel case to be consistent with
AddressInput
field names.It fixes #4514 and it fixes #4541.
Pull Request Checklist